Issue #78 update PG drivers #85
Conversation
|
I think I would not bother updating the driver for simplesender. I didn't even realize what that code did until I looked at it. It hasn't been touched in 13 years. That library was added 18 years ago. My best guess is that it was part of some undocumented test process. I don't believe it was included in the mirth distributions, and it doesn't look like it even gets built as part of the normal build process. We probably need to evaluate to see if we want to get rid of it, and if we decide to keep it with the existing postgres functionality, it should be using a modern driver. |
jonbartels
left a comment
jonbartels
left a comment
There was a problem hiding this comment.
Do not update the JARS in simplesender. They are not packaged in the OIE server or client.
|
@tonygermano - I agree with you. I filed #88 |
Signed-off-by: Richard Ogin <rogin@users.noreply.github.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Ignore me asking CoPilot to review please. |
5 participants
Issue #78
Pulled latest v42.6.x from here. SHA1 hash verified. Sonatype showed it having zero vulnerabilities.
Could not find other PG jar at version "-405". Pulled latest "-408" version here. 2007 timestamp. SHA1 hash verified.
Code compiled w/exception of KeyEncryptorTest, which I deleted. All failed tests ignored.
Ignore the tool listing two renames - two files were deleted, and two files were added.