Minor changes to experiments list command

Author: BartoszCki

paperspace/commands/experiments.py

@@ -56,6 +56,7 @@ def __init__(self, api=experiments_api, logger_=logger):
         self.logger = logger_
 
     def execute(self, project_handles=None):
+        project_handles = project_handles or []
         params = self._get_query_params(project_handles)
         response = self.api.get("/experiments/", params=params)
 
@@ -68,9 +69,7 @@ def execute(self, project_handles=None):
 
     @staticmethod
     def _get_query_params(project_handles):
-        # TODO: change to limit: -1 when PS-9535 is deployed to production
-        # to list all experiments
-        params = {"limit": 1000000}
+        params = {"limit": -1}  # so the API sends back full list without pagination
         for i, handle in enumerate(project_handles):
             key = "projectHandle[{}]".format(i)
             params[key] = handle

paperspace/config.py

@@ -16,7 +16,7 @@ def get_api_key(config_dir_path, config_file_name):
 
 _DEFAULT_CONFIG_HOST = "https://api.paperspace.io"
 _DEFAULT_CONFIG_LOG_HOST = "https://logs.paperspace.io"
-_DEFAULT_CONFIG_EXPERIMENTS_HOST = "https://services.paperspace.io/experiments/v1/"  # TODO: validate this
+_DEFAULT_CONFIG_EXPERIMENTS_HOST = "https://services.paperspace.io/experiments/v1/"
 _DEFAULT_CONFIG_DIR_PATH = "~/.paperspace"
 _DEFAULT_CONFIG_FILE_NAME = os.path.expanduser("config.json")
 

tests/functional/test_experiments.py

@@ -747,7 +747,7 @@ def test_should_send_get_request_and_print_list_of_experiments(self, get_patched
         get_patched.assert_called_once_with(self.URL,
                                             headers=self.EXPECTED_HEADERS,
                                             json=None,
-                                            params={"limit": 1000000})
+                                            params={"limit": -1})
 
         assert result.output == self.DETAILS_STDOUT
         assert self.EXPECTED_HEADERS["X-API-Key"] != "some_key"
@@ -765,7 +765,7 @@ def test_should_send_get_request_and_paginate_list_when_output_table_len_is_gt_l
         get_patched.assert_called_once_with(self.URL,
                                             headers=self.EXPECTED_HEADERS,
                                             json=None,
-                                            params={"limit": 1000000})
+                                            params={"limit": -1})
 
         pydoc_patched.pager.assert_called_once()
         assert result.exit_code == 0
@@ -781,7 +781,7 @@ def test_should_send_get_request_and_print_list_of_experiments_filtered_with_two
         get_patched.assert_called_once_with(self.URL,
                                             headers=self.EXPECTED_HEADERS,
                                             json=None,
-                                            params={"limit": 1000000,
+                                            params={"limit": -1,
                                                     "projectHandle[0]": u"handle1",
                                                     "projectHandle[1]": u"handle2"})
 
@@ -799,7 +799,7 @@ def test_should_send_get_request_and_print_list_of_experiments_filtered_with_two
         get_patched.assert_called_once_with(self.URL,
                                             headers=self.EXPECTED_HEADERS,
                                             json=None,
-                                            params={"limit": 1000000,
+                                            params={"limit": -1,
                                                     "projectHandle[0]": u"handle1",
                                                     "projectHandle[1]": u"handle2"})