fix: getRelationship

-  getRelationship now returns undefined if the base property is not an ObjectId
- getRelationships return empty array if base property is not an array

Author: Rmannn

package.json

@@ -1,6 +1,6 @@
 {
     "name": "nestjs-mongo",
-    "version": "0.14.0",
+    "version": "0.14.1",
     "description": "A NestJS module that provide a simple mongodb orm like",
     "keywords": [
         "nestjs",

src/entity/manager.ts

@@ -390,7 +390,10 @@ export class EntityManager {
             );
         }
 
-        const id: ObjectId = obj[property];
+        const id: ObjectId | undefined | null = obj[property];
+        if (!(id instanceof ObjectId)) {
+            return;
+        }
         const filter: Filter<R> = {};
         filter._id = id;
         const relationship = await this.findOne<R>(relationMetadata.type, filter, options);
@@ -423,6 +426,9 @@ export class EntityManager {
         }
 
         const value = obj[property];
+        if (!Array.isArray(value)) {
+            return [];
+        }
         const relationshipsCursor = await this.find<R>(
             relationMetadata.type,
             {

test/relationship/relationship.spec.ts

@@ -216,6 +216,23 @@ describe('Relationship', () => {
                         )
                     ).toHaveLength(2);
                 });
+
+                it('should return undefined for single relationship', async () => {
+                    const entityRelationShip = new EntityRelationship();
+                    entityRelationShip.property = 'test_with_no_parent';
+
+                    const notFound = await em.getRelationship(entityRelationShip, 'parent');
+                    expect(notFound).toBeUndefined();
+                });
+
+                it('should return undefined for multiple children relationships', async () => {
+                    const entityRelationShip = new EntityRelationship();
+                    entityRelationShip.property = 'test_with_no_children';
+
+                    const notFound = await em.getRelationships(entityRelationShip, 'children');
+                    expect(notFound).toBeInstanceOf(Array);
+                    expect(notFound).toHaveLength(0);
+                });
             });
         });
     });