Finally fixed the Secret initialization problem! Added $ROAMING$ functionallity for bookmarks.

Author: Harri Klingsten

src/PainKiller.PowerCommands/Core/PainKiller.PowerCommands.Configuration/ConfigurationService.cs

@@ -64,16 +64,12 @@ private ConfigurationService(){}
     /// <param name="defaultIfMissing"></param>
     /// <param name="inputFileName"></param>
     /// <returns></returns>
-    public YamlContainer<T> GetAppDataConfiguration<T>(T defaultIfMissing, string inputFileName = "") where T : new()
+    public YamlContainer<T> GetAppDataConfiguration<T>(string inputFileName = "") where T : new()
     {
         var directory = $"{Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData)}\\{nameof(PowerCommands)}";
         if (!Directory.Exists(directory)) Directory.CreateDirectory(directory);
         var fileName = Path.Combine(directory, inputFileName);
-        if (!File.Exists(fileName))
-        {
-            var yaml = CreateContent(defaultIfMissing);
-            File.WriteAllText(fileName, yaml);
-        }
+        if (!File.Exists(fileName)) throw new FileNotFoundException($"Could not find file {fileName}");
         var yamlContent = File.ReadAllText(fileName);
         var deserializer = new DeserializerBuilder()
             .WithNamingConvention(CamelCaseNamingConvention.Instance)

src/PainKiller.PowerCommands/Core/PainKiller.PowerCommands.Configuration/Contracts/IConfigurationService.cs

@@ -7,5 +7,5 @@ public interface IConfigurationService
     YamlContainer<T> Get<T>(string inputFileName = "") where T : new();
     string SaveChanges<T>(T configuration, string inputFileName = "") where T : new();
     void Create<T>(T configuration, string fullFileName) where T : new();
-    YamlContainer<T> GetAppDataConfiguration<T>(T defaultIfMissing, string inputFileName = "") where T : new();
+    YamlContainer<T> GetAppDataConfiguration<T>(string inputFileName = "") where T : new();
 }

src/PainKiller.PowerCommands/Core/PainKiller.PowerCommands.Core/Commands/CdCommand.cs

@@ -2,7 +2,7 @@
 
 [PowerCommandTest(        tests: " ")]
 [PowerCommandDesign(description: "Change or view the current working directory",
-                        options: "bookmark",
+                        options: "bookmark|roaming",
              disableProxyOutput: true,
                         example: "//View current working directory|cd|//Traverse down one directory|//Change working directory|cd ..|cd \"C:\\ProgramData\"|//Set bookmark as the working directory using name|cd --bookmark program|//Set bookmark as the working directory using index|cd --bookmark 0|//Set first existing bookmark (if any) as working directory|cd --bookmark")]
 public class CdCommand : CommandBase<CommandsConfiguration>, IWorkingDirectoryChangesListener
@@ -44,6 +44,10 @@ public override RunResult Run()
         {
             path = Configuration.Bookmark.Bookmarks.First().Path;
         }
+        else if (HasOption("roaming"))
+        {
+            path = ConfigurationGlobals.ApplicationDataFolder;
+        }
         else if (!string.IsNullOrEmpty(inputPath))
         {
             path = inputPath;
@@ -61,7 +65,7 @@ public override RunResult Run()
             if(!string.IsNullOrEmpty(dir)) paths.Add(dir);
             path = string.Join(Path.DirectorySeparatorChar, paths);
         }
-
+        if (path.Contains("$ROAMING$")) path = path.Replace("$ROAMING$", ConfigurationGlobals.ApplicationDataFolder);
         if (Directory.Exists(path)) WorkingDirectory = path;
         else WriteFailureLine($"[{path}] does not exist");
         ShowDirectories();

src/PainKiller.PowerCommands/Core/PainKiller.PowerCommands.Core/Commands/SecretCommand.cs

@@ -45,13 +45,13 @@ private RunResult Salt()
 
     private RunResult Init()
     {
-        var salt = IEncryptionService.GetRandomSalt();
-        WriteLine($"{salt.Length}");
-        var firstHalf = salt.Substring(0, 22);
-        var secondHalf = salt.Substring(22, 22);
+        var firstHalf = IEncryptionService.GetRandomSalt();;
+        var secondHalf = IEncryptionService.GetRandomSalt();;
         Environment.SetEnvironmentVariable("_encryptionManager", firstHalf, EnvironmentVariableTarget.User);
         var securityConfig = new SecurityConfiguration { Encryption = new EncryptionConfiguration { SharedSecretEnvironmentKey = "_encryptionManager", SharedSecretSalt = secondHalf } };
-        StorageService<SecurityConfiguration>.Service.StoreObject(securityConfig, ConfigurationGlobals.SecurityFileName);
+        var fileName = Path.Combine(ConfigurationGlobals.ApplicationDataFolder, ConfigurationGlobals.SecurityFileName);
+        ConfigurationService.Service.Create(securityConfig, fileName);
+        WriteSuccessLine($"File {fileName} saved OK, you will need to restart the application before the changes take effect.");
         return Ok();
     }
 

src/PainKiller.PowerCommands/Core/PainKiller.PowerCommands.Core/Services/EncryptionService.cs

@@ -4,7 +4,7 @@ public class EncryptionService : IEncryptionService
 {
     private EncryptionService()
     {
-        var securityConfiguration = ConfigurationService.Service.GetAppDataConfiguration(new SecurityConfiguration { Encryption = new EncryptionConfiguration { SharedSecretEnvironmentKey = nameof(_encryptionManager), SharedSecretSalt = IEncryptionService.GetRandomSalt() } }, ConfigurationGlobals.SecurityFileName).Configuration;
+        var securityConfiguration = ConfigurationService.Service.GetAppDataConfiguration<SecurityConfiguration>(ConfigurationGlobals.SecurityFileName).Configuration;
         _salt = securityConfiguration.Encryption.SharedSecretSalt;
         _sharedSecret = Environment.GetEnvironmentVariable(securityConfiguration.Encryption.SharedSecretEnvironmentKey, EnvironmentVariableTarget.User) ?? string.Empty;
         if (string.IsNullOrEmpty(_sharedSecret)) ConsoleService.Service.WriteWarning(nameof(EncryptionService),$"The environment variable [{securityConfiguration.Encryption.SharedSecretEnvironmentKey}] is missing, you should generate a salt with secret --salt\nAnd then create the environment variable with the salt as value with user scope, before you create secrets (otherwise you need to re-create them again)");

src/PainKiller.PowerCommands/PainKiller.PowerCommands.Bootstrap/Startup.cs

@@ -1,14 +1,24 @@
 using Microsoft.Extensions.Logging;
+using PainKiller.PowerCommands.Configuration;
+using PainKiller.PowerCommands.Configuration.DomainObjects;
 using PainKiller.PowerCommands.Core.Managers;
 using PainKiller.PowerCommands.Core.Services;
 using PainKiller.PowerCommands.MyExampleCommands;
 using PainKiller.PowerCommands.MyExampleCommands.Configuration;
+using PainKiller.PowerCommands.Shared.Contracts;
 
 namespace PainKiller.PowerCommands.Bootstrap;
 public static class Startup
 {
     public static PowerCommandsManager ConfigureServices()
     {
+        if (!Directory.Exists(ConfigurationGlobals.ApplicationDataFolder))
+        {
+            Directory.CreateDirectory(ConfigurationGlobals.ApplicationDataFolder);
+            InitSecret();
+            ConsoleService.Service.WriteSuccessLine(nameof(Startup), "\nFirst startup basic application configuration completed...");
+            ConsoleService.Service.WriteSuccessLine(nameof(Startup), "You will need to restart the application before the changes take effect.");
+        }
         var services = PowerCommandServices.Service;
 
         services.Configuration.Environment.InitializeValues();
@@ -33,4 +43,14 @@ public static PowerCommandsManager ConfigureServices()
         ConsoleService.Service.WriteLine(nameof(Startup), "\nUse up or down key  to cycle trough command history.", null);
         return new PowerCommandsManager(services);
     }
+
+    private static void InitSecret()
+    {
+        var firstHalf = IEncryptionService.GetRandomSalt();;
+        var secondHalf = IEncryptionService.GetRandomSalt();;
+        Environment.SetEnvironmentVariable("_encryptionManager", firstHalf, EnvironmentVariableTarget.User);
+        var securityConfig = new SecurityConfiguration { Encryption = new EncryptionConfiguration { SharedSecretEnvironmentKey = "_encryptionManager", SharedSecretSalt = secondHalf } };
+        var fileName = Path.Combine(ConfigurationGlobals.ApplicationDataFolder, ConfigurationGlobals.SecurityFileName);
+        ConfigurationService.Service.Create(securityConfig, fileName);
+    }
 }