finalised dot source detection and notification

Author: Razmo99

src/PowerShellEditorServices/Services/PowerShell/Handlers/PrepareRenameSymbol.cs

@@ -55,14 +55,18 @@ public async Task<PrepareRenameSymbolResult> Handle(PrepareRenameSymbolParams re
                 };
                 // ast is FunctionDefinitionAst or CommandAst or VariableExpressionAst or StringConstantExpressionAst &&
                 SymbolReference symbol = scriptFile.References.TryGetSymbolAtPosition(request.Line + 1, request.Column + 1);
-                Ast token = Utilities.GetAst(request.Line + 1,request.Column + 1,scriptFile.ScriptAst);
+                Ast token = Utilities.GetAst(request.Line + 1, request.Column + 1, scriptFile.ScriptAst);
 
                 if (token == null)
                 {
                     result.message = "Unable to find symbol";
                     return result;
                 }
-
+                if (Utilities.AssertContainsDotSourced(scriptFile.ScriptAst))
+                {
+                    result.message = "Dot Source detected, this is currently not supported operation aborted";
+                    return result;
+                }
                 switch (token)
                 {
                     case FunctionDefinitionAst funcDef:
@@ -87,28 +91,17 @@ public async Task<PrepareRenameSymbolResult> Handle(PrepareRenameSymbolParams re
 
                     case VariableExpressionAst or CommandAst or CommandParameterAst or ParameterAst or StringConstantExpressionAst:
                         {
-
-                            try
+                            IterativeVariableRename visitor = new(request.RenameTo,
+                                                token.Extent.StartLineNumber,
+                                                token.Extent.StartColumnNumber,
+                                                scriptFile.ScriptAst);
+                            if (visitor.TargetVariableAst == null)
                             {
-                                IterativeVariableRename visitor = new(request.RenameTo,
-                                                    token.Extent.StartLineNumber,
-                                                    token.Extent.StartColumnNumber,
-                                                    scriptFile.ScriptAst);
-                                if (visitor.TargetVariableAst == null)
-                                {
-                                    result.message = "Failed to find variable definition within the current file";
-                                }
+                                result.message = "Failed to find variable definition within the current file";
                             }
-                            catch (TargetVariableIsDotSourcedException)
-                            {
-
-                                result.message = "Variable is dot sourced which is currently not supported unable to perform a rename";
-                            }
-
                             break;
                         }
                 }
-
                 return result;
             }).ConfigureAwait(false);
         }

src/PowerShellEditorServices/Services/PowerShell/Refactoring/Exceptions.cs

@@ -22,23 +22,6 @@ public TargetSymbolNotFoundException(string message, Exception inner)
         }
     }
 
-    public class TargetVariableIsDotSourcedException : Exception
-    {
-        public TargetVariableIsDotSourcedException()
-        {
-        }
-
-        public TargetVariableIsDotSourcedException(string message)
-            : base(message)
-        {
-        }
-
-        public TargetVariableIsDotSourcedException(string message, Exception inner)
-            : base(message, inner)
-        {
-        }
-    }
-
     public class FunctionDefinitionNotFoundException : Exception
     {
         public FunctionDefinitionNotFoundException()

src/PowerShellEditorServices/Services/PowerShell/Refactoring/IterativeVariableVisitor.cs

@@ -19,7 +19,6 @@ internal class IterativeVariableRename
         internal int StartLineNumber;
         internal int StartColumnNumber;
         internal VariableExpressionAst TargetVariableAst;
-        internal List<string> dotSourcedScripts = new();
         internal readonly Ast ScriptAst;
         internal bool isParam;
         internal bool AliasSet;