address pr comments

Author: Benny1007

src/PowerShellGet/private/functions/New-NugetPackage.ps1

@@ -91,17 +91,15 @@ function New-NugetPackage {
         $process.Start() | Out-Null
         $process.WaitForExit()
 
+        if (Test-Path -Path $tempPath) {
+            Remove-Item -Path $tempPath -Force -Recurse
+        }
+
         if (-Not ($process.ExitCode -eq 0 )) {
-            if (Test-Path -Path $tempPath) {
-                Remove-Item -Path $tempPath -Force -Recurse
-            }
             $stdOut = $process.StandardOut.ReadToEnd()
             throw "dotnet cli failed to pack $stdOut"
         }
 
-        if (Test-Path -Path $tempPath) {
-            Remove-Item -Path $tempPath -Force -Recurse
-        }
     }
 
     $stdOut = $process.StandardOutput.ReadLine()

src/PowerShellGet/private/functions/New-NuspecFile.ps1

@@ -62,8 +62,7 @@ function New-NuspecFile {
     $Tags = $Tags -Join " "
 
     if ($Tags.Length -gt 4000) {
-        $Tags = $Tags.Substring(0, $Tags.LastIndexOf(" "))
-        Write-Warning -Message "Nuspec 'Tag' list exceeded max 4000 characters and was truncated."
+        Write-Warning -Message "Tag list exceeded 4000 characters and may not be accepted by some Nuget feeds."
     }
 
     $metaDataElementsHash = [ordered]@{
@@ -121,5 +120,8 @@ function New-NuspecFile {
 
     $xml.AppendChild($packageElement) | Out-Null
 
-    $xml.save("$OutputPath\$Id.nuspec")
+    $nuspecFullName = Join-Path -Path $OutputPath -ChildPath "$Id.nuspec"
+    $xml.save($nuspecFullName)
+
+    Write-Output $nuspecFullName
 }

src/PowerShellGet/private/functions/Publish-PSArtifactUtility.ps1

@@ -342,7 +342,6 @@ function Publish-PSArtifactUtility {
             $VersionString = "$($Dependency.MinimumVersion)"
         }
 
-        # fix#335 refactor to construct object to pass to new New-NuspecFile function.
         $props = @{
             id      = $ModuleName
             version = $VersionString
@@ -352,7 +351,6 @@ function Publish-PSArtifactUtility {
         $dependencies += $dependencyObject
     }
 
-    # fix#335 refactor to use new New-NuspecFile function.
     $params = @{
         OutputPath               = $NugetPackageRoot
         Id                       = $Name
@@ -371,14 +369,12 @@ function Publish-PSArtifactUtility {
     }
 
     try {
-        New-NuspecFile $params
-        $NuspecFullName = Join-Path -Path $NugetPackageRoot -ChildPath "$Name.nuspec"
+        $NuspecFullName = New-NuspecFile $params
     }
     catch {
         Write-Error -Message "Failed to create nuspec file $_.Exception" -ErrorAction Stop
     }
 
-    # fix#335 Refactor to use new New-NugetPackage function.
     try {
         if ($DotnetCommandPath) {
             New-NugetPackage -NuspecPath $NuspecFullName -NugetPackageRoot $NugetPackageRoot -UseDotnetCli -Verbose:$VerbosePreference
@@ -403,7 +399,6 @@ function Publish-PSArtifactUtility {
         Write-Error -Message $message -ErrorId $errorId -Category InvalidOperation -ErrorAction Stop
     }
 
-    # Fix#335 refactor to use new Publish-NugetPackage function.
     try {
         if ($DotnetCommandPath) {
             Publish-NugetPackage -NupkgPath $NupkgFullName -Destination $Destination -NugetApiKey $NugetApiKey -UseDotnetCli -Verbose:$VerbosePreference