Use powerShellDefaultVersion everywhere and stop using powerShellExePath (#2304)

* Use powerShellDefaultVersion everywhere and stop using powerShellExePath

* add modify settings in session menu

* re-add powerShellExePath to package.json so vscode api can update it and remove references to developer.powerShellExePath

* actually use setting...

* still switch even if workspace setting is set

* rob's feedback

Author: TylerLeonhardt

package.json

@@ -499,12 +499,6 @@
           "default": [],
           "description": "Specify array of Modules to exclude from Command Explorer listing."
         },
-        "powershell.powerShellExePath": {
-          "type": "string",
-          "default": "",
-          "scope": "machine",
-          "description": "Specifies the full path to a PowerShell executable. Changes the installation of PowerShell used for language and debugging services."
-        },
         "powershell.powerShellAdditionalExePaths": {
           "type": "array",
           "description": "Specifies an array of versionName / exePath pairs where exePath points to a non-standard install location for PowerShell and versionName can be used to reference this path with the powershell.powerShellDefaultVersion setting.",
@@ -530,7 +524,13 @@
         },
         "powershell.powerShellDefaultVersion": {
           "type": "string",
-          "description": "Specifies the PowerShell version name, as displayed by the 'PowerShell: Show Session Menu' command, used when the extension loads e.g \"Windows PowerShell (x86)\" or \"PowerShell Core 6 (x64)\"."
+          "description": "Specifies the PowerShell version name, as displayed by the 'PowerShell: Show Session Menu' command, used when the extension loads e.g \"Windows PowerShell (x86)\" or \"PowerShell Core 6 (x64)\". You can specify additional PowerShell executables by using the \"powershell.powerShellAdditionalExePaths\" setting."
+        },
+        "powershell.powerShellExePath": {
+          "type": "string",
+          "default": "",
+          "scope": "machine",
+          "description": "REMOVED. Please use the \"powershell.powerShellDefaultVersion\" setting instead."
         },
         "powershell.promptToUpdatePowerShell": {
           "type": "boolean",

src/features/GenerateBugReport.ts

@@ -113,7 +113,7 @@ ${tableHeader}\n${table};
 
     private getRuntimeInfo() {
 
-        const powerShellExePath = this.sessionManager.getPowerShellExePath();
+        const powerShellExePath = this.sessionManager.PowerShellExeDetails.exePath;
         const powerShellArgs = [
             "-NoProfile",
             "-Command",