Enable 'noImplicitReturns', 'noFallthroughCasesInSwitch' and 'noUnusedParameters'

Author: andyleejordan

src/features/Console.ts

@@ -60,9 +60,7 @@ interface IShowInputPromptResponseBody {
 }
 
 
-function showChoicePrompt(
-    promptDetails: IShowChoicePromptRequestArgs,
-    client: LanguageClient): Thenable<IShowChoicePromptResponseBody> {
+function showChoicePrompt(promptDetails: IShowChoicePromptRequestArgs): Thenable<IShowChoicePromptResponseBody> {
 
     let resultThenable: Thenable<IShowChoicePromptResponseBody>;
 
@@ -226,7 +224,7 @@ export class ConsoleFeature extends LanguageClientConsumer {
         this.handlers = [
             this.languageClient.onRequest(
                 ShowChoicePromptRequestType,
-                (promptDetails) => showChoicePrompt(promptDetails, this.languageClient)),
+                (promptDetails) => showChoicePrompt(promptDetails)),
 
             this.languageClient.onRequest(
                 ShowInputPromptRequestType,

src/features/CustomViews.ts

@@ -100,13 +100,12 @@ class PowerShellContentProvider implements vscode.TextDocumentContentProvider {
 
     public closeView(id: string) {
         const uriString = this.getUri(id);
-        const view: CustomView = this.viewIndex[uriString];
 
         vscode.workspace.textDocuments.some((doc) => {
             if (doc.uri.toString() === uriString) {
                 vscode.window
                     .showTextDocument(doc)
-                    .then((editor) => vscode.commands.executeCommand("workbench.action.closeActiveEditor"));
+                    .then((_) => vscode.commands.executeCommand("workbench.action.closeActiveEditor"));
 
                 return true;
             }

src/features/ExtensionCommands.ts

@@ -320,12 +320,12 @@ export class ExtensionCommandsFeature extends LanguageClientConsumer {
                 a.name.localeCompare(b.name));
     }
 
-    private showExtensionCommands(client: LanguageClient): Thenable<IInvokeExtensionCommandRequestArguments> {
+    private showExtensionCommands(client: LanguageClient): Thenable<void> {
         // If no extension commands are available, show a message
         if (this.extensionCommands.length === 0) {
             vscode.window.showInformationMessage(
                 "No extension commands have been loaded into the current session.");
-            return;
+            return undefined;
         }
 
         const quickPickItems =
@@ -337,7 +337,7 @@ export class ExtensionCommandsFeature extends LanguageClientConsumer {
                 };
             });
 
-        vscode.window
+        return vscode.window
             .showQuickPick(
                 quickPickItems,
                 { placeHolder: "Select a command" })
@@ -418,7 +418,7 @@ export class ExtensionCommandsFeature extends LanguageClientConsumer {
             promise =
                 vscode.workspace.openTextDocument(filePath)
                     .then((doc) => vscode.window.showTextDocument(doc))
-                    .then((editor) => vscode.commands.executeCommand("workbench.action.closeActiveEditor"))
+                    .then((_) => vscode.commands.executeCommand("workbench.action.closeActiveEditor"))
                     .then((_) => EditorOperationResponse.Completed);
         } else {
             promise = Promise.resolve(EditorOperationResponse.Completed);

src/features/GenerateBugReport.ts

@@ -89,6 +89,7 @@ ${this.generateExtensionTable(extensions)}
             if (e.packageJSON.isBuiltin === false) {
                 return `|${e.packageJSON.name}|${e.packageJSON.publisher}|${e.packageJSON.version}|`;
             }
+            return undefined;
         }).join("\n");
 
         const extensionTable = `

src/features/GetCommands.ts

@@ -101,7 +101,7 @@ class CommandsExplorerProvider implements vscode.TreeDataProvider<Command> {
         return element;
     }
 
-    public getChildren(element?: Command): Thenable<Command[]> {
+    public getChildren(_element?: Command): Thenable<Command[]> {
         return Promise.resolve(this.powerShellCommands || []);
     }
 }
@@ -135,7 +135,7 @@ class Command extends vscode.TreeItem {
         };
     }
 
-    public async getChildren(element?): Promise<Command[]> {
+    public async getChildren(_element?): Promise<Command[]> {
         return [];
         // Returning an empty array because we need to return something.
     }

src/features/RemoteFiles.ts

@@ -66,9 +66,10 @@ export class RemoteFilesFeature extends LanguageClientConsumer {
 
                 return vscode.window
                     .showTextDocument(doc)
-                    .then((editor) => vscode.commands.executeCommand("workbench.action.closeActiveEditor"))
+                    .then((_) => vscode.commands.executeCommand("workbench.action.closeActiveEditor"))
                     .then((_) => innerCloseFiles());
             }
+            return undefined;
         }
 
         innerCloseFiles();

src/platform.ts

@@ -104,6 +104,7 @@ export class PowerShellExeFinder {
         for await (const pwsh of this.enumeratePowerShellInstallations()) {
             return pwsh;
         }
+        return undefined;
     }
 
     /**
@@ -244,6 +245,9 @@ export class PowerShellExeFinder {
 
             case OperatingSystem.Windows:
                 return await this.findPSCoreWindowsInstallation();
+
+            case OperatingSystem.Unknown:
+                return undefined;
         }
     }
 
@@ -257,6 +261,9 @@ export class PowerShellExeFinder {
 
             case OperatingSystem.Windows:
                 return await this.findPSCoreWindowsInstallation({ findPreview: true });
+
+            case OperatingSystem.Unknown:
+                return undefined;
         }
     }
 

tsconfig.json

@@ -13,9 +13,9 @@
     "rootDir": ".",
     // TODO: We need to enable stricter checking...
     // "strict": true,
-    // "noImplicitReturns": true,
-    // "noFallthroughCasesInSwitch": true,
-    // "noUnusedParameters": true
+    "noImplicitReturns": true,
+    "noFallthroughCasesInSwitch": true,
+    "noUnusedParameters": true
   },
   "include": [ "src", "test" ],
 }