spi: spi-qpic-snand: fix NAND_READ_LOCATION_2 register handling

juhosg · broonie · commit 36fd6275818e · 2025-04-30T09:38:16.000+09:00
The precomputed value for the NAND_READ_LOCATION_2 register should be stored in 'snandc->regs->read_location2'. Fix the qcom_spi_set_read_loc_first() function accordingly. Fixes: 7304d19 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface") Signed-off-by: Gabor Juhos <j4g8y7@gmail.com> Reviewed-by: Md Sadre Alam <quic_mdalam@quicinc.com> Link: https://patch.msgid.link/20250428-qpic-snand-readloc2-fix-v1-1-50ce0877ff72@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/drivers/spi/spi-qpic-snand.c b/drivers/spi/spi-qpic-snand.c
@@ -142,7 +142,7 @@ static void qcom_spi_set_read_loc_first(struct qcom_nand_controller *snandc,
 	else if (reg == NAND_READ_LOCATION_1)
 		snandc->regs->read_location1 = locreg_val;
 	else if (reg == NAND_READ_LOCATION_2)
-		snandc->regs->read_location1 = locreg_val;
+		snandc->regs->read_location2 = locreg_val;
 	else if (reg == NAND_READ_LOCATION_3)
 		snandc->regs->read_location3 = locreg_val;
 }

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ static void qcom_spi_set_read_loc_first(struct qcom_nand_controller *snandc,`
`142`	`142`	`else if (reg == NAND_READ_LOCATION_1)`
`143`	`143`	`snandc->regs->read_location1 = locreg_val;`
`144`	`144`	`else if (reg == NAND_READ_LOCATION_2)`
`145`		`- snandc->regs->read_location1 = locreg_val;`
	`145`	`+ snandc->regs->read_location2 = locreg_val;`
`146`	`146`	`else if (reg == NAND_READ_LOCATION_3)`
`147`	`147`	`snandc->regs->read_location3 = locreg_val;`
`148`	`148`	`}`