Skip to content

Commit 44ebbe4

Browse files
Remove broken marker from MKLLUFactorization JET test
MKLLUFactorization JET test behavior is system-dependent, not predictable by: - Julia version (passes on some LTS systems, fails on others) - OS (passes on some Linux systems, fails on others) - Platform (behavior varies even within same OS) The JET analysis depends on specific system configuration (MKL installation, system libraries, etc.) that we cannot detect reliably in the test suite. Solution: Remove broken marker entirely. Let the test: - Pass when the system has good type stability (informative success) - Fail when the system has runtime dispatch (informative failure) "Unexpected Pass" errors are worse than occasional failures because they block test suites that are actually working correctly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 434cad4 commit 44ebbe4

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

test/nopre/jet.jl

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -97,15 +97,11 @@ end
9797

9898
# Platform-specific factorizations (may not be available on all systems)
9999
if @isdefined(MKLLUFactorization)
100-
# MKLLUFactorization has platform-specific JET behavior:
101-
# - Linux + Julia < 1.12: runtime dispatch in BLAS logging (broken)
102-
# - macOS/other + any version: passes
103-
# - All platforms + Julia >= 1.12: passes (improved type inference)
104-
if Sys.islinux() && VERSION < v"1.12.0-"
105-
JET.@test_opt solve(prob, MKLLUFactorization()) broken=true
106-
else
107-
JET.@test_opt solve(prob, MKLLUFactorization())
108-
end
100+
# MKLLUFactorization JET behavior is system-dependent (not just Julia version or OS).
101+
# Some systems have runtime dispatch in BLAS logging, others don't.
102+
# Don't mark as broken - let it pass when it works and fail when it doesn't.
103+
# "Unexpected Pass" errors are worse than informative failures.
104+
JET.@test_opt solve(prob, MKLLUFactorization())
109105
end
110106

111107
if Sys.isapple() && @isdefined(AppleAccelerateLUFactorization)

0 commit comments

Comments
 (0)