Commit a76034d
Fix BLAS logging type stability issues
Fixed three issues in blas_logging.jl:
1. Line 69: Bug comparing info <= size where 'size' was the Base.size function
instead of a matrix dimension variable. Simplified to provide generic error
message for ggev/gges failures.
2. Line 121: Runtime dispatch from string interpolation with Dict{Symbol,Any}
values. Added _format_context_pair type barrier function with ::String
return annotation to isolate dispatch and prevent propagation.
These fixes improve type stability throughout the BLAS logging code, reducing
from 3 runtime dispatches to 1 isolated dispatch in rarely-called logging code.
The remaining dispatch in _format_context_pair is acceptable as it's:
- Behind a type barrier (doesn't propagate to callers)
- In logging code that only runs on BLAS errors (rare)
- Inherent to working with Dict{Symbol,Any} context data
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>1 parent d12057d commit a76034d
2 files changed
+11
-11
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
78 | 72 | | |
79 | 73 | | |
80 | 74 | | |
| |||
92 | 86 | | |
93 | 87 | | |
94 | 88 | | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
95 | 93 | | |
96 | 94 | | |
97 | 95 | | |
| |||
124 | 122 | | |
125 | 123 | | |
126 | 124 | | |
127 | | - | |
| 125 | + | |
| 126 | + | |
128 | 127 | | |
129 | 128 | | |
130 | 129 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
| 80 | + | |
| 81 | + | |
81 | 82 | | |
82 | 83 | | |
83 | 84 | | |
| |||
0 commit comments