Merge pull request #2557 from SciML/myb/nonsq

Fix iteration bounds in `tearing_with_dummy_derivatives`

Author: YingboMa

docs/src/tutorials/parameter_identifiability.md

@@ -78,7 +78,8 @@ Let's try to check specific parameters and their combinations
 
 ```julia
 to_check = [de.k5, de.k7, de.k10 / de.k9, de.k5 + de.k6]
-local_id_some = assess_local_identifiability(de, funcs_to_check = to_check, prob_threshold = 0.99)
+local_id_some = assess_local_identifiability(
+    de, funcs_to_check = to_check, prob_threshold = 0.99)
 ```
 
 Notice that in this case, everything (except the unknown variable $x_7$) is locally identifiable, including combinations such as $k_{10}/k_9, k_5+k_6$

src/structural_transformation/partial_state_selection.jl

@@ -351,7 +351,7 @@ function tearing_with_dummy_derivatives(structure, dummy_derivatives)
         Base.Fix1(isdiffed, (structure, dummy_derivatives)),
         Union{Unassigned, SelectedState};
         varfilter = Base.Fix1(getindex, can_eliminate))
-    for v in eachindex(var_eq_matching)
+    for v in 𝑑vertices(structure.graph)
         is_present(structure, v) || continue
         dv = var_to_diff[v]
         (dv === nothing || !is_some_diff(structure, dummy_derivatives, dv)) && continue