Fix test cases

Author: ChrisRackauckas

test/components.jl

@@ -98,9 +98,9 @@ let
     @named rc_model2 = compose(_rc_model2,
         [resistor, resistor2, capacitor, source, ground])
     sys2 = structural_simplify(rc_model2)
-    prob2 = ODEProblem(sys2, u0, (0, 10.0))
+    prob2 = ODEProblem(sys2, [], (0, 10.0), guesses = u0)
     sol2 = solve(prob2, Rosenbrock23())
-    @test sol2[source.p.i] ≈ sol2[rc_model2.source.p.i] ≈ -sol2[capacitor.i]
+    @test sol2[source.p.i] ≈ sol2[rc_model2.source.p.i] ≈ sol2[capacitor.i]
 end
 
 # Outer/inner connections
@@ -155,7 +155,7 @@ include("../examples/serial_inductor.jl")
 sys = structural_simplify(ll_model)
 @test length(equations(sys)) == 2
 u0 = unknowns(sys) .=> 0
-@test_nowarn ODEProblem(sys, u0, (0, 10.0))
+@test_nowarn ODEProblem(sys, [], (0, 10.0), guesses = u0, warn_initialize_determined = false)
 prob = DAEProblem(sys, D.(unknowns(sys)) .=> 0, u0, (0, 0.5))
 sol = solve(prob, DFBDF())
 @test sol.retcode == SciMLBase.ReturnCode.Success

test/state_selection.jl

@@ -45,16 +45,16 @@ end
 # 1516
 let
     @connector function Fluid_port(; name, p = 101325.0, m = 0.0, T = 293.15)
-        sts = @variables p(t)=p m(t)=m [connect = Flow] T(t)=T [connect = Stream]
+        sts = @variables p(t) [guess=p] m(t) [guess = m, connect = Flow] T(t) [guess=T, connect = Stream]
         ODESystem(Equation[], t, sts, []; name = name)
     end
-
+    
     #this one is for latter
     @connector function Heat_port(; name, Q = 0.0, T = 293.15)
-        sts = @variables T(t)=T Q(t)=Q [connect = Flow]
+        sts = @variables T(t) [guess=T] Q(t) [guess = Q, connect = Flow]
         ODESystem(Equation[], t, sts, []; name = name)
     end
-
+    
     # like ground but for fluid systems (fluid_port.m is expected to be zero in closed loop)
     function Compensator(; name, p = 101325.0, T_back = 273.15)
         @named fluid_port = Fluid_port()
@@ -63,7 +63,7 @@ let
                fluid_port.T ~ T_back]
         compose(ODESystem(eqs, t, [], ps; name = name), fluid_port)
     end
-
+    
     function Source(; name, delta_p = 100, T_feed = 293.15)
         @named supply_port = Fluid_port() # expected to feed connected pipe -> m<0
         @named return_port = Fluid_port() # expected to receive from connected pipe -> m>0
@@ -74,7 +74,7 @@ let
                return_port.T ~ T_feed]
         compose(ODESystem(eqs, t, [], ps; name = name), [supply_port, return_port])
     end
-
+    
     function Substation(; name, T_return = 343.15)
         @named supply_port = Fluid_port() # expected to receive from connected pipe -> m>0
         @named return_port = Fluid_port() # expected to feed connected pipe -> m<0
@@ -85,12 +85,12 @@ let
                return_port.T ~ T_return]
         compose(ODESystem(eqs, t, [], ps; name = name), [supply_port, return_port])
     end
-
+    
     function Pipe(; name, L = 1000, d = 0.1, N = 100, rho = 1000, f = 1)
         @named fluid_port_a = Fluid_port()
         @named fluid_port_b = Fluid_port()
         ps = @parameters L=L d=d rho=rho f=f N=N
-        sts = @variables v(t)=0.0 dp_z(t)=0.0
+        sts = @variables v(t) [guess=0.0] dp_z(t) [guess=0.0]
         eqs = [fluid_port_a.m ~ -fluid_port_b.m
                fluid_port_a.T ~ instream(fluid_port_a.T)
                fluid_port_b.T ~ fluid_port_a.T
@@ -114,18 +114,18 @@ let
                connect(return_pipe.fluid_port_a, source.return_port)]
         compose(ODESystem(eqs, t, [], ps; name = name), subs)
     end
-
+    
     @named system = System(L = 10)
     @unpack supply_pipe, return_pipe = system
     sys = structural_simplify(system)
     u0 = [
         system.supply_pipe.v => 0.1, system.return_pipe.v => 0.1, D(supply_pipe.v) => 0.0,
         D(return_pipe.fluid_port_a.m) => 0.0,
         D(supply_pipe.fluid_port_a.m) => 0.0]
-    prob1 = ODEProblem(sys, u0, (0.0, 10.0), [])
-    prob2 = ODEProblem(sys, u0, (0.0, 10.0), [])
+    prob1 = ODEProblem(sys, [], (0.0, 10.0), [], guesses = u0)
+    prob2 = ODEProblem(sys, [], (0.0, 10.0), [], guesses = u0)
     prob3 = DAEProblem(sys, D.(unknowns(sys)) .=> 0.0, u0, (0.0, 10.0), [])
-    @test solve(prob1, FBDF()).retcode == ReturnCode.Success
+    @test solve(prob1, FBDF()).retcode == ReturnCode.Success    
     #@test solve(prob2, FBDF()).retcode == ReturnCode.Success
     @test solve(prob3, DFBDF()).retcode == ReturnCode.Success
 end

test/structural_transformation/index_reduction.jl

@@ -144,14 +144,13 @@ let sys = structural_simplify(pendulum2)
         D(D(y)) => 0.0,
         x => sqrt(2) / 2,
         y => sqrt(2) / 2,
-        T => 0.0
     ]
     p = [
         L => 1.0,
         g => 9.8
     ]
 
-    prob_auto = ODEProblem(sys, u0, (0.0, 0.5), p)
+    prob_auto = ODEProblem(sys, u0, (0.0, 0.5), p, guesses = [T => 0.0])
     sol = solve(prob_auto, FBDF())
     @test sol.retcode == ReturnCode.Success
     @test norm(sol[x] .^ 2 + sol[y] .^ 2 .- 1) < 1e-2