fix: error when all parameters are not initialized

Author: AayushSabharwal

src/systems/parameter_buffer.jl

@@ -43,14 +43,32 @@ function MTKParameters(
     p = merge(defs, p)
     p = merge(Dict(unwrap(k) => v for (k, v) in p),
         Dict(default_toterm(unwrap(k)) => v for (k, v) in p))
-    p = Dict(k => fixpoint_sub(v, p) for (k, v) in p)
+    p = Dict(unwrap(k) => fixpoint_sub(v, p) for (k, v) in p)
     for (sym, _) in p
         if istree(sym) && operation(sym) === getindex &&
            first(arguments(sym)) in all_ps
             error("Scalarized parameter values ($sym) are not supported. Instead of `[p[1] => 1.0, p[2] => 2.0]` use `[p => [1.0, 2.0]]`")
         end
     end
 
+    missing_params = Set()
+    for idxmap in (ic.tunable_idx, ic.discrete_idx, ic.constant_idx, ic.nonnumeric_idx)
+        for sym in keys(idxmap)
+            sym isa Symbol && continue
+            haskey(p, sym) && continue
+            hasname(sym) && haskey(p, getname(sym)) && continue
+            ttsym = default_toterm(sym)
+            haskey(p, ttsym) && continue
+            hasname(ttsym) && haskey(p, getname(ttsym)) && continue
+
+            istree(sym) && operation(sym) === getindex && haskey(p, arguments(sym)[1]) &&
+                continue
+            push!(missing_params, sym)
+        end
+    end
+
+    isempty(missing_params) || throw(MissingVariablesError(collect(missing_params)))
+
     tunable_buffer = Tuple(Vector{temp.type}(undef, temp.length)
     for temp in ic.tunable_buffer_sizes)
     disc_buffer = Tuple(Vector{temp.type}(undef, temp.length)

test/mtkparameters.jl

@@ -121,3 +121,16 @@ ps = MTKParameters(sys, [p => 1.0, q => 2.0, r => 3.0])
 newps = remake_buffer(sys, ps, Dict(p => 1.0f0))
 @test newps.tunable[1] isa Vector{Float32}
 @test newps.tunable[1] == [1.0f0, 2.0f0, 3.0f0]
+
+# Issue#2624
+@parameters p d
+@variables X(t)
+eqs = [D(X) ~ p - d * X]
+@mtkbuild sys = ODESystem(eqs, t)
+
+u0 = [X => 1.0]
+tspan = (0.0, 100.0)
+ps = [p => 1.0] # Value for `d` is missing
+
+@test_throws ModelingToolkit.MissingVariablesError ODEProblem(sys, u0, tspan, ps)
+@test_nowarn ODEProblem(sys, u0, tspan, [ps..., d => 1.0])