Merge pull request #2532 from SciML/myb/struct

Specialize symbolic `Struct`

Author: ChrisRackauckas

Project.toml

@@ -104,7 +104,7 @@ SpecialFunctions = "0.7, 0.8, 0.9, 0.10, 1.0, 2"
 StaticArrays = "0.10, 0.11, 0.12, 1.0"
 SymbolicIndexingInterface = "0.3.1"
 SymbolicUtils = "1.0"
-Symbolics = "5.20.1"
+Symbolics = "5.24"
 URIs = "1"
 UnPack = "0.1, 1.0"
 Unitful = "1.1"

src/systems/index_cache.jl

@@ -3,6 +3,11 @@ struct BufferTemplate
     length::Int
 end
 
+function BufferTemplate(s::Type{<:Symbolics.Struct}, length::Int)
+    T = Symbolics.juliatype(s)
+    BufferTemplate(T, length)
+end
+
 const DEPENDENT_PORTION = :dependent
 const NONNUMERIC_PORTION = :nonnumeric
 

src/systems/parameter_buffer.jl

@@ -1,3 +1,5 @@
+symconvert(::Type{Symbolics.Struct{T}}, x) where {T} = convert(T, x)
+symconvert(::Type{T}, x) where {T} = convert(T, x)
 struct MTKParameters{T, D, C, E, N, F, G}
     tunable::T
     discrete::D
@@ -81,7 +83,7 @@ function MTKParameters(sys::AbstractSystem, p; tofloat = false, use_union = fals
     for (sym, val) in p
         sym = unwrap(sym)
         ctype = concrete_symtype(sym)
-        val = convert(ctype, fixpoint_sub(val, p))
+        val = symconvert(ctype, fixpoint_sub(val, p))
         done = set_value(sym, val)
         if !done && Symbolics.isarraysymbolic(sym)
             done = all(set_value.(collect(sym), val))