refactor: remove deprecated items

Author: AayushSabharwal

src/ModelingToolkit.jl

@@ -128,10 +128,6 @@ $(TYPEDEF)
 TODO
 """
 abstract type AbstractSystem end
-abstract type AbstractTimeDependentSystem <: AbstractSystem end
-abstract type AbstractTimeIndependentSystem <: AbstractSystem end
-abstract type AbstractMultivariateSystem <: AbstractSystem end
-abstract type AbstractOptimizationSystem <: AbstractTimeIndependentSystem end
 
 function independent_variable end
 
@@ -150,7 +146,6 @@ include("independent_variables.jl")
 include("constants.jl")
 
 include("utils.jl")
-include("domains.jl")
 
 include("systems/index_cache.jl")
 include("systems/parameter_buffer.jl")
@@ -265,25 +260,19 @@ PrecompileTools.@compile_workload begin
     end
 end
 
-export AbstractTimeDependentSystem,
-       AbstractTimeIndependentSystem,
-       AbstractMultivariateSystem
-
-export ODEFunction, ODEFunctionExpr, ODEProblemExpr, convert_system_indepvar,
+export ODEFunction, convert_system_indepvar,
        System, OptimizationSystem, JumpSystem, SDESystem, NonlinearSystem
-export DAEFunctionExpr, DAEProblemExpr
-export SDEFunction, SDEFunctionExpr, SDEProblemExpr
+export SDEFunction
 export SystemStructure
-export DiscreteProblem, DiscreteFunction, DiscreteFunctionExpr
-export ImplicitDiscreteProblem, ImplicitDiscreteFunction,
-       ImplicitDiscreteFunctionExpr
+export DiscreteProblem, DiscreteFunction
+export ImplicitDiscreteProblem, ImplicitDiscreteFunction
 export ODEProblem, SDEProblem
-export NonlinearFunction, NonlinearFunctionExpr
-export NonlinearProblem, NonlinearProblemExpr
-export IntervalNonlinearFunction, IntervalNonlinearFunctionExpr
-export IntervalNonlinearProblem, IntervalNonlinearProblemExpr
-export OptimizationProblem, OptimizationProblemExpr, constraints
-export SteadyStateProblem, SteadyStateProblemExpr
+export NonlinearFunction
+export NonlinearProblem
+export IntervalNonlinearFunction
+export IntervalNonlinearProblem
+export OptimizationProblem, constraints
+export SteadyStateProblem
 export JumpProblem
 export alias_elimination, flatten
 export connect, domain_connect, @connector, Connection, AnalysisPoint, Flow, Stream,
@@ -315,7 +304,7 @@ export calculate_jacobian, generate_jacobian, generate_rhs, generate_custom_func
 export calculate_control_jacobian, generate_control_jacobian
 export calculate_tgrad, generate_tgrad
 export generate_cost, calculate_cost_gradient, generate_cost_gradient
-export calculate_factorized_W, generate_factorized_W
+export calculate_factorized_W
 export calculate_cost_hessian, generate_cost_hessian
 export calculate_massmatrix, generate_diffusion_function
 export stochastic_integral_transform

src/domains.jl

@@ -207,24 +207,6 @@ Substitutions(subs, deps) = Substitutions(subs, deps, nothing)
 Base.nameof(sys::AbstractSystem) = getfield(sys, :name)
 description(sys::AbstractSystem) = has_description(sys) ? get_description(sys) : ""
 
-#Deprecated
-function independent_variable(sys::AbstractSystem)
-    Base.depwarn(
-        "`independent_variable` is deprecated. Use `get_iv` or `independent_variables` instead.",
-        :independent_variable)
-    isdefined(sys, :iv) ? getfield(sys, :iv) : nothing
-end
-
-function independent_variables(sys::AbstractTimeDependentSystem)
-    return [getfield(sys, :iv)]
-end
-
-independent_variables(::AbstractTimeIndependentSystem) = []
-
-function independent_variables(sys::AbstractMultivariateSystem)
-    return getfield(sys, :ivs)
-end
-
 """
 $(TYPEDSIGNATURES)
 
@@ -233,9 +215,6 @@ Get the independent variable(s) of the system `sys`.
 See also [`@independent_variables`](@ref) and [`ModelingToolkit.get_iv`](@ref).
 """
 function independent_variables(sys::AbstractSystem)
-    if !(sys isa System)
-        @warn "Please declare ($(typeof(sys))) as a subtype of `AbstractTimeDependentSystem`, `AbstractTimeIndependentSystem` or `AbstractMultivariateSystem`."
-    end
     if isdefined(sys, :iv) && getfield(sys, :iv) !== nothing
         return [getfield(sys, :iv)]
     elseif isdefined(sys, :ivs)
@@ -309,8 +288,6 @@ function SymbolicIndexingInterface.variable_index(sys::AbstractSystem, sym::Symb
     return nothing
 end
 
-SymbolicIndexingInterface.variable_symbols(sys::AbstractMultivariateSystem) = sys.dvs
-
 function SymbolicIndexingInterface.variable_symbols(sys::AbstractSystem)
     return solved_unknowns(sys)
 end
@@ -561,9 +538,6 @@ function SymbolicIndexingInterface.default_values(sys::AbstractSystem)
     )
 end
 
-SymbolicIndexingInterface.is_time_dependent(::AbstractTimeDependentSystem) = true
-SymbolicIndexingInterface.is_time_dependent(::AbstractTimeIndependentSystem) = false
-
 SymbolicIndexingInterface.is_markovian(sys::AbstractSystem) = !is_dde(sys)
 
 SymbolicIndexingInterface.constant_structure(::AbstractSystem) = true
@@ -1645,9 +1619,6 @@ function observables(sys::AbstractSystem)
     return map(eq -> eq.lhs, observed(sys))
 end
 
-Base.@deprecate default_u0(x) defaults(x) false
-Base.@deprecate default_p(x) defaults(x) false
-
 """
 $(TYPEDSIGNATURES)
 

src/systems/abstractsystem.jl

@@ -34,7 +34,7 @@ domains = [t ∈ (0.0,1.0),
 @named pde_system = PDESystem(eq,bcs,domains,[t,x],[u])
 ```
 """
-struct PDESystem <: ModelingToolkit.AbstractMultivariateSystem
+struct PDESystem <: AbstractSystem
     "The equations which define the PDE."
     eqs::Any
     "The boundary conditions."
@@ -166,5 +166,3 @@ function Base.show(io::IO, ::MIME"text/plain", sys::PDESystem)
     print(io, "Default Parameter Values", get_defaults(sys))
     return nothing
 end
-
-SymbolicIndexingInterface.is_time_dependent(::AbstractMultivariateSystem) = true

src/systems/pde/pdesystem.jl

@@ -60,8 +60,6 @@ macro showarr(x)
     end
 end
 
-@deprecate substitute_expr!(expr, s) substitute(expr, s)
-
 function todict(d)
     eltype(d) <: Pair || throw(ArgumentError("The variable-value mapping must be a Dict."))
     d isa Dict ? d : Dict(d)