fixed updater to not tell "errors" if exit code is 1

exit code is now ignored, could help with issue #4

Author: Skycoder42

src/autoupdatercore/updater_p.cpp

@@ -162,24 +162,18 @@ void UpdaterPrivate::updaterReady(int exitCode, QProcess::ExitStatus exitStatus)
 			mainProcess->deleteLater();
 			mainProcess = nullptr;
 
-			if(lastErrorCode != EXIT_SUCCESS) {
-				running = false;
-				emit q->runningChanged(false);
+			running = false;
+			emit q->runningChanged(false);
+			try {
+				updateInfos = parseResult(updateOut);
+				if(!updateInfos.isEmpty())
+					emit q->updateInfoChanged(updateInfos);
+				emit q->checkUpdatesDone(!updateInfos.isEmpty(), false);
+			} catch (NoUpdatesXmlException &) {
+				emit q->checkUpdatesDone(false, false);
+			} catch (InvalidXmlException &exc) {
+				lastErrorLog = exc.what();
 				emit q->checkUpdatesDone(false, true);
-			} else {
-				running = false;
-				emit q->runningChanged(false);
-				try {
-					updateInfos = parseResult(updateOut);
-					if(!updateInfos.isEmpty())
-						emit q->updateInfoChanged(updateInfos);
-					emit q->checkUpdatesDone(!updateInfos.isEmpty(), false);
-				} catch (NoUpdatesXmlException &) {
-					emit q->checkUpdatesDone(false, false);
-				} catch (InvalidXmlException &exc) {
-					lastErrorLog = exc.what();
-					emit q->checkUpdatesDone(false, true);
-				}
 			}
 		} else
 			updaterError(QProcess::Crashed);

src/autoupdatergui/translations/QtAutoUpdaterController_de.ts

@@ -4,7 +4,7 @@
 <context>
     <name>AdminAuthorization</name>
     <message>
-        <location filename="../adminauthorization_x11.cpp" line="+189"/>
+        <location filename="../adminauthorization_x11.cpp" line="+188"/>
         <source>Enter Password</source>
         <translation>Passwort Eingeben</translation>
     </message>

src/autoupdatergui/translations/QtAutoUpdaterController_template.ts

@@ -4,7 +4,7 @@
 <context>
     <name>AdminAuthorization</name>
     <message>
-        <location filename="../adminauthorization_x11.cpp" line="+189"/>
+        <location filename="../adminauthorization_x11.cpp" line="+188"/>
         <source>Enter Password</source>
         <translation type="unfinished"></translation>
     </message>

tests/auto/autoupdatercore/UpdaterTest/tst_updatertest.cpp

@@ -66,8 +66,8 @@ void UpdaterTest::testUpdateCheck_data()
 	QString homePath = QStandardPaths::writableLocation(QStandardPaths::HomeLocation);
 	QString path = homePath + "/QtAutoUpdaterTestInstaller";
 	QTest::newRow("QtAutoUpdaterTestInstaller") << path + "/maintenancetool"
-									<< true
-									<< updates;
+												<< true
+												<< updates;
 
 	updates.clear();
 
@@ -77,8 +77,8 @@ void UpdaterTest::testUpdateCheck_data()
 	path = homePath + "/Qt";
 #endif
 	QTest::newRow("Qt") << path + "/MaintenanceTool"
-									<< false
-									<< updates;
+						<< false
+						<< updates;
 }
 
 void UpdaterTest::testUpdateCheck()
@@ -119,7 +119,7 @@ void UpdaterTest::testUpdateCheck()
 	QVariantList varList = this->checkSpy->takeFirst();
 	QVERIFY(this->updater->exitedNormally());
 	QCOMPARE(this->updater->errorCode(), hasUpdates ? EXIT_SUCCESS : EXIT_FAILURE);
-	QCOMPARE(varList[1].toBool(), !hasUpdates);
+	QCOMPARE(varList[1].toBool(), false);//no errors please
 
 	//verifiy the "hasUpdates" and "updates" are as expected
 	QCOMPARE(varList[0].toBool(), hasUpdates);