restore binary compability (via testing)

Author: Skycoder42

appveyor.yml

@@ -10,8 +10,8 @@ environment:
   MAKE_RUN_TESTS: true #experimental
 
   matrix:
-    - PLATFORM: mingw53_32
     - PLATFORM: msvc2017_64
+    - PLATFORM: mingw53_32
     - PLATFORM: winrt_x64_msvc2017
     - PLATFORM: winrt_x86_msvc2017
     - PLATFORM: winrt_armv7_msvc2017

src/mvvmcore/viewmodel.cpp

@@ -64,7 +64,7 @@ void ViewModel::showForResult(quint32 requestCode, const QMetaObject *viewMetaOb
 	showImp(viewMetaObject, params, const_cast<ViewModel*>(this), requestCode);
 }
 
-void ViewModel::showImp(const QMetaObject *metaObject, QVariantHash params, QPointer<ViewModel> parent, quint32 requestCode)
+void ViewModel::showImp(const QMetaObject *metaObject, const QVariantHash &params, QPointer<ViewModel> parent, quint32 requestCode)
 {
 	QMetaObject::invokeMethod(CoreAppPrivate::dInstance().data(), "showViewModel", Qt::QueuedConnection,
 							  Q_ARG(const QMetaObject*, metaObject),

src/mvvmcore/viewmodel.h

@@ -61,7 +61,7 @@ public Q_SLOTS:
 
 	QScopedPointer<ViewModelPrivate> d;
 
-	static void showImp(const QMetaObject *metaObject, QVariantHash params, QPointer<ViewModel> parent, quint32 requestCode = 0);
+	static void showImp(const QMetaObject *metaObject, const QVariantHash &params, QPointer<ViewModel> parent, quint32 requestCode = 0);
 };
 
 //TODO doc