Skip to content

Commit 8ba2b46

Browse files
authored
fix: log missing event handlers (#158)
1 parent 36d2eb3 commit 8ba2b46

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

lib/smart-app.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -587,6 +587,7 @@ class SmartApp {
587587
results.push(handler(context, event.deviceEvent, event.eventTime))
588588
break
589589
} else {
590+
this._log.error(`Device event handler '${handlerName}' not defined`)
590591
responder.respond({statusCode: 422, eventData: {}})
591592
return
592593
}
@@ -599,6 +600,7 @@ class SmartApp {
599600
results.push(handler(context, event.timerEvent, event.eventTime))
600601
break
601602
} else {
603+
this._log.error(`Timer event handler '${handlerName}' not defined`)
602604
responder.respond({statusCode: 422, eventData: {}})
603605
return
604606
}
@@ -636,6 +638,7 @@ class SmartApp {
636638
results.push(handler(context, event.deviceLifecycleEvent, event.eventTime))
637639
break
638640
} else {
641+
this._log.error(`Device lifecycle event handler '${handlerName}' not defined`)
639642
responder.respond({statusCode: 422, eventData: {}})
640643
return
641644
}
@@ -649,6 +652,7 @@ class SmartApp {
649652
results.push(handler(context, event.deviceHealthEvent, event.eventTime))
650653
break
651654
} else {
655+
this._log.error(`Device health event handler '${handlerName}' not defined`)
652656
responder.respond({statusCode: 422, eventData: {}})
653657
return
654658
}
@@ -662,6 +666,7 @@ class SmartApp {
662666
results.push(handler(context, event.hubHealthEvent, event.eventTime))
663667
break
664668
} else {
669+
this._log.error(`Hub health event handler '${handlerName}' not defined`)
665670
responder.respond({statusCode: 422, eventData: {}})
666671
return
667672
}
@@ -675,6 +680,7 @@ class SmartApp {
675680
results.push(handler(context, event.modeEvent, event.eventTime))
676681
break
677682
} else {
683+
this._log.error(`Mode event handler '${handlerName}' not defined`)
678684
responder.respond({statusCode: 422, eventData: {}})
679685
return
680686
}
@@ -688,6 +694,7 @@ class SmartApp {
688694
results.push(handler(context, event.securityArmStateEvent, event.eventTime))
689695
break
690696
} else {
697+
this._log.error(`Security arm state event handler '${handlerName}' not defined`)
691698
responder.respond({statusCode: 422, eventData: {}})
692699
return
693700
}
@@ -701,6 +708,7 @@ class SmartApp {
701708
results.push(handler(context, event.sceneLifecycleEvent, event.eventTime))
702709
break
703710
} else {
711+
this._log.error(`Scene lifecycle event handler '${handlerName}' not defined`)
704712
responder.respond({statusCode: 422, eventData: {}})
705713
return
706714
}

0 commit comments

Comments
 (0)