Skip to content

Commit a5fa15e

Browse files
authored
Merge pull request #3 from erodewald/standardization
2 parents c0551d1 + af16492 commit a5fa15e

File tree

5 files changed

+90
-9
lines changed

5 files changed

+90
-9
lines changed

.github/PULL_REQUEST_TEMPLATE/PR_CHECKLIST_TEMPLATE.md renamed to .github/PULL_REQUEST_TEMPLATE.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ assignees: erodewald
1414
- [ ] Bug fix (non-breaking change which fixes an issue)
1515
- [ ] New feature (non-breaking change which adds functionality)
1616
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
17-
- [ ] I have read the **CONTRIBUTING** document.
17+
- [ ] I have read the **[CONTRIBUTING](/CONTRIBUTING.md)** document
1818
- [ ] My code follows the code style of this project (hint: install an [xo editor plugin](https://github.com/xojs/xo#editor-plugins))
19-
- [ ] My change requires a change to the documentation.
20-
- [ ] I have updated the documentation accordingly.
21-
- [ ] I have added tests to cover my changes.
22-
- [ ] All new and existing tests passed.
19+
- [ ] My change requires a change to the documentation
20+
- [ ] I have updated the documentation accordingly
21+
- [ ] I have added tests to cover my changes
22+
- [ ] All new and existing tests passed

CONTRIBUTING.md

Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
# Contributing
2+
3+
Thanks for contributing! Our community of developers is what put SmartThings on the map!
4+
5+
## How can I contribute?
6+
7+
### Improve documentation
8+
9+
As a user of the SmartApp SDK, you're the perfect candidate to help us improve our documentation. Error fixes, typo corrections, better explanations, more examples, etc. Open issues for things that could be improved – anything. Even improvements to this document.
10+
11+
### Give feedback on issues
12+
13+
We're always looking for more opinions on discussions in the issue tracker. It's a good opportunity to influence the future direction of this SDK.
14+
15+
### [Submitting an issue or feature request](/issues/new/choose)
16+
17+
- Search the issue tracker before opening an issue
18+
- Ensure you're using the latest version
19+
- Use a clear and descriptive title
20+
- Include as much information as possible by filling out the issue template
21+
- The more time you put into an issue, the more we will
22+
23+
### [Submitting a pull request](/compare)
24+
25+
- Non-trivial changes are often best discussed in an issue first, to prevent you from doing unnecessary work.
26+
- For ambitious tasks, you should try to get your work in front of the community for feedback as soon as possible. Open a pull request as soon as you have done the minimum needed to demonstrate your idea. At this early stage, don't worry about making things perfect, or 100% complete. Add a `[WIP]` prefix to the title, and describe what you still need to do. This lets reviewers know not to nit-pick small details or point out improvements you already know you need to make.
27+
- Don't include unrelated changes
28+
- New features should be accompanied with tests and documentation
29+
- Use a clear and descriptive title for the pull request and commits
30+
- Lint and test before submitting the pull request by running `$ npm test`
31+
- Write a convincing description of why we should land your pull request. Answer _why_ it's needed and provide use-cases.
32+
- Make the pull request from a [topic branch](https://github.com/dchelimsky/rspec/wiki/Topic-Branches) (not master)
33+
- You might be asked to do changes to your pull request. There's never a need to open another pull request – [just update the existing one.](https://github.com/RichardLitt/knowledge/blob/master/github/amending-a-commit-guide.md)
34+
35+
## [Finding contributions to work on](labels/help%20wanted)
36+
37+
Look at the existing issues for areas of contribution. Searching for issues labeled `help wanted` would be a great place to start.
38+
39+
---
40+
41+
## More about SmartThings
42+
43+
If you are not familiar with SmartThings, we have
44+
[extensive on-line documentation](https://smartthings.developer.samsung.com/develop/index.html).
45+
46+
To create and manage your services and devices on SmartThings, create an account in the
47+
[developer workspace](https://devworkspace.developer.samsung.com/).
48+
49+
The [SmartThings Community](https://community.smartthings.com/c/developers/) is a good place share and
50+
ask questions.
51+
52+
There is also a [SmartThings reddit community](https://www.reddit.com/r/SmartThings/) where you
53+
can read and share information.
54+
55+
## License and Copyright
56+
57+
Licensed under the [Apache License, Version 2.0](https://www.apache.org/licenses/LICENSE-2.0)
58+
59+
Copyright 2019 SmartThings, Inc.

LICENSE.txt renamed to LICENSE

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Apache License
1+
Apache License
22
Version 2.0, January 2004
33
http://www.apache.org/licenses/
44

@@ -186,7 +186,7 @@ Apache License
186186
same "printed page" as the copyright notice for easier
187187
identification within third-party archives.
188188

189-
Copyright 2012-2017 Amazon.com, Inc. or its affiliates. All Rights Reserved.
189+
Copyright 2019 SmartThings, Inc.
190190

191191
Licensed under the Apache License, Version 2.0 (the "License");
192192
you may not use this file except in compliance with the License.

README.md

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,4 +121,26 @@ server.use(bodyParser.json());
121121
server.post('/', function(req, response) {
122122
smartapp.handleHttpCallback(req, response);
123123
});
124-
```
124+
```
125+
126+
---
127+
128+
## More about SmartThings
129+
130+
If you are not familiar with SmartThings, we have
131+
[extensive on-line documentation](https://smartthings.developer.samsung.com/develop/index.html).
132+
133+
To create and manage your services and devices on SmartThings, create an account in the
134+
[developer workspace](https://devworkspace.developer.samsung.com/).
135+
136+
The [SmartThings Community](https://community.smartthings.com/c/developers/) is a good place share and
137+
ask questions.
138+
139+
There is also a [SmartThings reddit community](https://www.reddit.com/r/SmartThings/) where you
140+
can read and share information.
141+
142+
## License and Copyright
143+
144+
Licensed under the [Apache License, Version 2.0](LICENSE)
145+
146+
Copyright 2019 SmartThings, Inc.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"mocha": "^5.2.0",
4141
"mockery": "^2.1.0",
4242
"xo": "^0.24.0"
43-
},
43+
},
4444
"xo": {
4545
"space": false,
4646
"semicolon": false,

0 commit comments

Comments
 (0)