Skip to content

Commit e0e374c

Browse files
authored
feat: update Core SDK to v5 (#227)
BREAKING CHANGE: The SmartThingsClient (context.api) has been updated which includes breaking changes to select devices and apps methods. The SDK will also no longer write OAuth client details to the context store if it is configured.
1 parent 77b8a7d commit e0e374c

File tree

4 files changed

+21947
-3345
lines changed

4 files changed

+21947
-3345
lines changed

.github/workflows/ci-cd.yaml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ jobs:
1414
runs-on: ubuntu-latest
1515

1616
steps:
17-
- uses: actions/checkout@v2
17+
- uses: actions/checkout@v3
1818
with:
1919
fetch-depth: 0
20-
- uses: actions/setup-node@v2
20+
- uses: actions/setup-node@v3
2121
with:
22-
node-version: 14
22+
node-version: 16
2323
cache: "npm"
2424
- run: npm ci --ignore-scripts
2525
- run: npx commitlint --from HEAD~${{ github.event.pull_request.commits }} --to HEAD
@@ -30,12 +30,12 @@ jobs:
3030
strategy:
3131
matrix:
3232
# add/remove versions as we move support forward
33-
node-version: [12, 14, 16]
33+
node-version: [14, 16, 18]
3434

3535
steps:
36-
- uses: actions/checkout@v2
36+
- uses: actions/checkout@v3
3737
- name: Use Node.js ${{ matrix.node-version }}
38-
uses: actions/setup-node@v2
38+
uses: actions/setup-node@v3
3939
with:
4040
node-version: ${{ matrix.node-version }}
4141
cache: "npm"
@@ -52,11 +52,11 @@ jobs:
5252
runs-on: ubuntu-latest
5353

5454
steps:
55-
- uses: actions/checkout@v2
55+
- uses: actions/checkout@v3
5656
- name: Setup Node.js
57-
uses: actions/setup-node@v2
57+
uses: actions/setup-node@v3
5858
with:
59-
node-version: 14
59+
node-version: 16
6060
cache: "npm"
6161
- run: npm ci
6262
- name: Release

lib/smart-app.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -450,8 +450,6 @@ class SmartApp {
450450
locationId: ctx.locationId,
451451
authToken: auth.access_token,
452452
refreshToken: auth.refresh_token,
453-
clientId: this._clientId,
454-
clientSecret: this._clientSecret,
455453
config: ctx.config
456454
})
457455
}
@@ -569,8 +567,6 @@ class SmartApp {
569567
locationId: context.locationId,
570568
authToken: context.authToken,
571569
refreshToken: context.refreshToken,
572-
clientId: this._clientId,
573-
clientSecret: this._clientSecret,
574570
config: context.config
575571
})
576572
}
@@ -588,8 +584,6 @@ class SmartApp {
588584
locationId: context.locationId,
589585
authToken: context.authToken,
590586
refreshToken: context.refreshToken,
591-
clientId: this._clientId,
592-
clientSecret: this._clientSecret,
593587
config: context.config
594588
})
595589
}

0 commit comments

Comments
 (0)