URL PATH of Actions - Controller Methods Refactoring

Author: thomaswoehlke

src/main/java/org/woehlke/simpleworklist/breadcrumb/Breadcrumb.java

@@ -1,5 +1,8 @@
 package org.woehlke.simpleworklist.breadcrumb;
 
+import lombok.EqualsAndHashCode;
+import lombok.Getter;
+import lombok.ToString;
 import org.woehlke.simpleworklist.project.Project;
 import org.woehlke.simpleworklist.task.Task;
 
@@ -8,12 +11,14 @@
 import java.util.List;
 import java.util.Locale;
 
+@Getter
+@EqualsAndHashCode
+@ToString
 public class Breadcrumb implements Serializable {
 
     private static final long serialVersionUID = 7932703111140692689L;
 
     private List<BreadcrumbItem> breadcrumb;
-
     private final Locale locale;
 
     public Breadcrumb(Locale locale) {
@@ -30,14 +35,6 @@ public Breadcrumb(Locale locale) {
         this.breadcrumb = breadcrumb;
     }
 
-    public List<BreadcrumbItem> getBreadcrumb() {
-        return breadcrumb;
-    }
-
-    public int size(){
-        return breadcrumb.size();
-    }
-
     public void addProjectRoot(){
         String urlProject = "/project/0";
         String name;

src/main/java/org/woehlke/simpleworklist/breadcrumb/BreadcrumbItem.java

@@ -1,9 +1,16 @@
 package org.woehlke.simpleworklist.breadcrumb;
 
+import lombok.*;
+
 import javax.validation.constraints.NotNull;
 import java.io.Serializable;
 import java.util.Objects;
 
+@Getter
+@Setter
+@NoArgsConstructor
+@EqualsAndHashCode
+@ToString
 public class BreadcrumbItem implements Serializable {
 
     private static final long serialVersionUID = 8276819198016077167L;
@@ -14,49 +21,9 @@ public class BreadcrumbItem implements Serializable {
     @NotNull
     private String url;
 
-    public String getName() {
-        return name;
-    }
-
-    public void setName(String name) {
-        this.name = name;
-    }
-
-    public String getUrl() {
-        return url;
-    }
-
-    public void setUrl(String url) {
-        this.url = url;
-    }
-
-    @Override
-    public boolean equals(Object o) {
-        if (this == o) return true;
-        if (!(o instanceof BreadcrumbItem)) return false;
-        BreadcrumbItem that = (BreadcrumbItem) o;
-        return getName().equals(that.getName()) &&
-                getUrl().equals(that.getUrl());
-    }
-
-    @Override
-    public int hashCode() {
-        return Objects.hash(getName(), getUrl());
-    }
-
-    @Override
-    public String toString() {
-        return "BreadcrumbItem{" +
-                "name='" + name + '\'' +
-                ", url='" + url + '\'' +
-                '}';
-    }
-
     public BreadcrumbItem(@NotNull String name, @NotNull String url) {
         this.name = name;
         this.url = url;
     }
 
-    public BreadcrumbItem() {
-    }
 }

src/main/java/org/woehlke/simpleworklist/breadcrumb/BreadcrumbServiceImpl.java

@@ -1,5 +1,6 @@
 package org.woehlke.simpleworklist.breadcrumb;
 
+import lombok.extern.slf4j.Slf4j;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.MessageSource;
 import org.springframework.stereotype.Service;
@@ -13,6 +14,7 @@
 import java.util.Locale;
 import java.util.Stack;
 
+@Slf4j
 @Service
 @Transactional(propagation = Propagation.REQUIRED, readOnly = true)
 public class BreadcrumbServiceImpl implements BreadcrumbService {
@@ -26,13 +28,15 @@ public BreadcrumbServiceImpl(MessageSource messageSource) {
 
     @Override
     public Breadcrumb getBreadcrumbForShowRootProject(Locale locale) {
+        log.info("getBreadcrumbForShowRootProject");
         Breadcrumb breadcrumb = new Breadcrumb(locale);
         breadcrumb.addProjectRoot();
         return breadcrumb;
     }
 
     @Override
     public Breadcrumb getBreadcrumbForShowOneProject(Project thisProject, Locale locale) {
+        log.info("getBreadcrumbForShowOneProject");
         Breadcrumb breadcrumb = new Breadcrumb(locale);
         breadcrumb.addProjectRoot();
             if (thisProject.getId() > 0) {
@@ -51,6 +55,7 @@ public Breadcrumb getBreadcrumbForShowOneProject(Project thisProject, Locale loc
 
     @Override
     public Breadcrumb getBreadcrumbForTaskstate(TaskState taskstate, Locale locale) {
+        log.info("getBreadcrumbForTaskstate");
         Breadcrumb breadcrumb = new Breadcrumb(locale);
         String code = taskstate.getCode();
         String name = messageSource.getMessage(code,null,locale);
@@ -60,6 +65,7 @@ public Breadcrumb getBreadcrumbForTaskstate(TaskState taskstate, Locale locale)
 
     @Override
     public Breadcrumb getBreadcrumbForTaskInTaskstate(String taskstate, Task task, Locale locale) {
+        log.info("getBreadcrumbForTaskInTaskstate");
         Breadcrumb breadcrumb = new Breadcrumb(locale);
         breadcrumb.addTaskstate(taskstate);
         breadcrumb.addTask(task);
@@ -68,6 +74,7 @@ public Breadcrumb getBreadcrumbForTaskInTaskstate(String taskstate, Task task, L
 
     @Override
     public Breadcrumb getBreadcrumbForTaskstateAll(Locale locale) {
+        log.info("getBreadcrumbForTaskstateAll");
         Breadcrumb breadcrumb = new Breadcrumb(locale);
         String code="layout.page.all";
         String name= messageSource.getMessage(code,null,locale);
@@ -78,6 +85,7 @@ public Breadcrumb getBreadcrumbForTaskstateAll(Locale locale) {
 
     @Override
     public Breadcrumb getBreadcrumbForTaskInProject(Project thisProject, Task task, Locale locale) {
+        log.info("getBreadcrumbForTaskInProject");
         Breadcrumb breadcrumb = new Breadcrumb(locale);
         breadcrumb.addProject(thisProject);
         breadcrumb.addTask(task);
@@ -86,6 +94,7 @@ public Breadcrumb getBreadcrumbForTaskInProject(Project thisProject, Task task,
 
     @Override
     public Breadcrumb getBreadcrumbForUserProfileAndMenu(Locale locale) {
+        log.info("getBreadcrumbForUserProfileAndMenu");
         Breadcrumb breadcrumb = new Breadcrumb(locale);
         String code="pages.user.profile";
         String name= messageSource.getMessage(code,null,locale);
@@ -96,6 +105,7 @@ public Breadcrumb getBreadcrumbForUserProfileAndMenu(Locale locale) {
 
     @Override
     public Breadcrumb getBreadcrumbForUserChangeName(Locale locale) {
+        log.info("getBreadcrumbForUserChangeName");
         Breadcrumb breadcrumb = new Breadcrumb(locale);
         String code="pages.user.profile";
         String name= messageSource.getMessage(code,null,locale);
@@ -110,6 +120,7 @@ public Breadcrumb getBreadcrumbForUserChangeName(Locale locale) {
 
     @Override
     public Breadcrumb getBreadcrumbForUserChangePassword(Locale locale) {
+        log.info("getBreadcrumbForUserChangePassword");
         Breadcrumb breadcrumb = new Breadcrumb(locale);
         String code="pages.user.profile";
         String name= messageSource.getMessage(code,null,locale);
@@ -124,6 +135,7 @@ public Breadcrumb getBreadcrumbForUserChangePassword(Locale locale) {
 
     @Override
     public Breadcrumb getBreadcrumbForUserContexts(Locale locale) {
+        log.info("getBreadcrumbForUserContexts");
         Breadcrumb breadcrumb = new Breadcrumb(locale);
         String code="pages.user.profile";
         String name= messageSource.getMessage(code,null,locale);
@@ -138,6 +150,7 @@ public Breadcrumb getBreadcrumbForUserContexts(Locale locale) {
 
     @Override
     public Breadcrumb getBreadcrumbForUserContextAdd(Locale locale) {
+        log.info("getBreadcrumbForUserContextAdd");
         Breadcrumb breadcrumb = new Breadcrumb(locale);
         String code="pages.user.profile";
         String name= messageSource.getMessage(code,null,locale);
@@ -152,6 +165,7 @@ public Breadcrumb getBreadcrumbForUserContextAdd(Locale locale) {
 
     @Override
     public Breadcrumb getBreadcrumbForUserContextEdit(Locale locale, Context context) {
+        log.info("getBreadcrumbForUserContextEdit");
         Breadcrumb breadcrumb = new Breadcrumb(locale);
         String code="pages.user.profile";
         String name= messageSource.getMessage(code,null,locale);
@@ -166,6 +180,7 @@ public Breadcrumb getBreadcrumbForUserContextEdit(Locale locale, Context context
 
     @Override
     public Breadcrumb getBreadcrumbForUserContextDelete(Locale locale, Context context) {
+        log.info("getBreadcrumbForUserContextDelete");
         Breadcrumb breadcrumb = new Breadcrumb(locale);
         String code="pages.user.profile";
         String name= messageSource.getMessage(code,null,locale);
@@ -180,6 +195,7 @@ public Breadcrumb getBreadcrumbForUserContextDelete(Locale locale, Context conte
 
     @Override
     public Breadcrumb getBreadcrumbForUserChangeLanguage(Locale locale) {
+        log.info("getBreadcrumbForUserChangeLanguage");
         Breadcrumb breadcrumb = new Breadcrumb(locale);
         String code="pages.user.profile";
         String name= messageSource.getMessage(code,null,locale);
@@ -194,6 +210,7 @@ public Breadcrumb getBreadcrumbForUserChangeLanguage(Locale locale) {
 
     @Override
     public Breadcrumb getBreadcrumbForMessagesBetweenCurrentAndOtherUser(Locale locale) {
+        log.info("getBreadcrumbForMessagesBetweenCurrentAndOtherUser");
         Breadcrumb breadcrumb = new Breadcrumb(locale);
         String code="pages.user.profile";
         String name= messageSource.getMessage(code,null,locale);
@@ -208,6 +225,7 @@ public Breadcrumb getBreadcrumbForMessagesBetweenCurrentAndOtherUser(Locale loca
 
     @Override
     public Breadcrumb getBreadcrumbForSearchResults(Locale locale) {
+        log.info("getBreadcrumbForSearchResults");
         Breadcrumb breadcrumb = new Breadcrumb(locale);
         String code="pages.user.profile";
         String name= messageSource.getMessage(code,null,locale);
@@ -220,5 +238,4 @@ public Breadcrumb getBreadcrumbForSearchResults(Locale locale) {
         return breadcrumb;
     }
 
-
 }