fixed #222, fixed #217, working on #215, working on #200

Author: phasenraum2010

src/main/java/org/woehlke/twitterwall/oodm/entities/Mention.java

@@ -98,7 +98,7 @@ private Mention() {
     @Transient
     @Override
     public String getUniqueId() {
-        return idTwitter.toString() +"_"+ screenNameUnique;
+        return "" + idTwitter +"_"+ screenNameUnique;
     }
 
     @Transient
@@ -125,7 +125,13 @@ public boolean isValid() {
         if(idTwitter == null){
             return false;
         }
-        return (this.getScreenName().compareTo(this.getScreenNameUnique())==0) ;
+        if(idTwitterOfUser < 0L){
+            return false;
+        }
+        if(this.getScreenName().toLowerCase().compareTo(this.getScreenNameUnique())!=0){
+            return false;
+        }
+        return true;
     }
 
     @Transient
@@ -245,6 +251,7 @@ public void setScreenNameUnique(String screenNameUnique) {
         this.screenNameUnique = screenNameUnique.toLowerCase();
     }
 
+    /*
     @Override
     public String toString() {
         return "Mention{" +
@@ -254,6 +261,19 @@ public String toString() {
             ", name='" + name + '\'' +
                 super.toString() +
             " }\n";
+    }*/
+
+    @Override
+    public String toString() {
+        return "Mention{" +
+                "id=" + id +
+                ", idTwitter=" + idTwitter +
+                ", screenName='" + screenName + '\'' +
+                ", screenNameUnique='" + screenNameUnique + '\'' +
+                ", name='" + name + '\'' +
+                ", idTwitterOfUser=" + idTwitterOfUser +
+                super.toString() +
+                '}';
     }
 
     @Override

src/main/java/org/woehlke/twitterwall/oodm/entities/parts/AbstractDomainObject.java

@@ -76,6 +76,7 @@ public String toString() {
             myExtraData.append(", ");
             myExtraData.append(extraData.get(extraDatumKey));
         }
+        myExtraData.append(" ] ");
         myExtraData.append(",\n createdBy=" + this.toStringCreatedBy());
         myExtraData.append(",\n updatedBy=" + this.toStringUpdatedBy());
         myExtraData.append(",\n taskInfo=" + this.toStringTaskInfo());

src/test/java/org/woehlke/twitterwall/oodm/entities/MentionTest.java

@@ -2,9 +2,13 @@
 
 import org.junit.Assert;
 import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class MentionTest implements DomainObjectMinimalTest  {
 
+    private static final Logger log = LoggerFactory.getLogger(MentionTest.class);
+
     //TODO: #197 https://github.com/phasenraum2010/twitterwall2/issues/197
     @Test
     @Override
@@ -43,7 +47,7 @@ public void getUniqueIdTest() throws Exception {
 
     //TODO: #197 https://github.com/phasenraum2010/twitterwall2/issues/197
     @Test
-    @Override
+    //@Override
     public void isValidTest() throws Exception {
         String msg = "isValidTest: ";
 
@@ -83,8 +87,13 @@ public void isValidTest() throws Exception {
         Mention mention2 = new Mention(createdBy,updatedBy,screenName2);
         Mention mention3 = new Mention(createdBy,updatedBy,idTwitter3,screenName3,name3);
 
+        log.info(msg+" mention1 "+mention1.toString()+" "+mention1.getUniqueId()+" "+mention1.isValid());
         Assert.assertTrue(msg,mention1.isValid());
+
+        log.info(msg+" mention2 "+mention2.toString()+" "+mention2.getUniqueId()+" "+mention2.isValid());
         Assert.assertTrue(msg,mention2.isValid());
+
+        log.info(msg+" mention3 "+mention3.toString()+" "+mention3.getUniqueId()+" "+mention3.isValid());
         Assert.assertTrue(msg,mention3.isValid());
 
         mention1.setScreenName(null);
@@ -97,11 +106,19 @@ public void isValidTest() throws Exception {
         mention4.setIdTwitter(idTwitter4);
         mention5.setIdTwitter(idTwitter4);
 
+        log.info(msg+" mention1 "+mention1.toString()+" "+mention1.getUniqueId()+" "+mention1.isValid());
         Assert.assertFalse(msg,mention1.isValid());
+
+        log.info(msg+" mention2 "+mention2.toString()+" "+mention2.getUniqueId()+" "+mention2.isValid());
         Assert.assertFalse(msg,mention2.isValid());
 
+        log.info(msg+" mention3 "+mention3.toString()+" "+mention3.getUniqueId()+" "+mention3.isValid());
         Assert.assertFalse(msg,mention3.isValid());
+
+        log.info(msg+" mention4 "+mention4.toString()+" "+mention4.getUniqueId()+" "+mention4.isValid());
         Assert.assertFalse(msg,mention4.isValid());
+
+        log.info(msg+" mention5 "+mention5.toString()+" "+mention5.getUniqueId()+" "+mention5.isValid());
         Assert.assertFalse(msg,mention5.isValid());
     }
 }