Skip to content

Commit 1a2d657

Browse files
committed
In JavaScriptEngineSwitcher.V8 now the Evaluate and Execute methods of V8ScriptEngine class are called with the discard parameter equal to false
1 parent edd0846 commit 1a2d657

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

NuGet/JavaScriptEngineSwitcher.V8/JavaScriptEngineSwitcher.V8.nuspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ This package does not contain the native ClearScript and V8 assemblies. Therefor
1717
* JavaScriptEngineSwitcher.V8.Native.win-x86
1818
* JavaScriptEngineSwitcher.V8.Native.win-x64</description>
1919
<summary>JavaScriptEngineSwitcher.V8 contains adapter `V8JsEngine` (wrapper for the Microsoft ClearScript.V8 version 5.4.8).</summary>
20+
<releaseNotes>Now the `Evaluate` and `Execute` methods of `V8ScriptEngine` class are called with the `discard` parameter equal to `false`.</releaseNotes>
2021
<copyright>Copyright (c) 2013-2017 Andrey Taritsyn - http://www.taritsyn.ru</copyright>
2122
<language>en-US</language>
2223
<tags>JavaScriptEngineSwitcher JavaScript ECMAScript V8 ClearScript</tags>

NuGet/JavaScriptEngineSwitcher.V8/readme.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,12 @@
2121
* JavaScriptEngineSwitcher.V8.Native.win-x86
2222
* JavaScriptEngineSwitcher.V8.Native.win-x64
2323

24+
=============
25+
RELEASE NOTES
26+
=============
27+
Now the `Evaluate` and `Execute` methods of `V8ScriptEngine` class are called
28+
with the `discard` parameter equal to `false`.
29+
2430
=============
2531
DOCUMENTATION
2632
=============

src/JavaScriptEngineSwitcher.V8/V8JsEngine.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ protected override object InnerEvaluate(string expression, string documentName)
264264
{
265265
try
266266
{
267-
result = _jsEngine.Evaluate(documentName, expression);
267+
result = _jsEngine.Evaluate(documentName, false, expression);
268268
}
269269
catch (OriginalJsException e)
270270
{
@@ -300,7 +300,7 @@ protected override void InnerExecute(string code, string documentName)
300300
{
301301
try
302302
{
303-
_jsEngine.Execute(documentName, code);
303+
_jsEngine.Execute(documentName, false, code);
304304
}
305305
catch (OriginalJsException e)
306306
{

0 commit comments

Comments
 (0)