From 43aab0d6597ea263cd5c9cd62adde17103c9dd59 Mon Sep 17 00:00:00 2001 From: Aditya-354 Date: Fri, 5 Dec 2025 22:30:18 +0530 Subject: [PATCH 1/3] Fixed overcomplicated quick_sort test range in CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 82d895c69f..bc2ed57dee 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -65,7 +65,7 @@ You can add new algorithms or data structures that are **not present in the repo // Let's make sure the array of numbers is ordered after calling the function. std::vector arr = {5, 3, 8, 12, 14, 16, 28, 96, 2, 5977}; std::vector arr_sorted = sorting::quick_sort::quick_sort( - arr, 0, int(std::end(arr) - std::begin(arr)) - 1); + arr, 0, arr.size() - 1); assert(std::is_sorted(std::begin(arr_sorted), std::end(arr_sorted))); ``` From c2c830c29aa7013707264f27945bff498dc1efb1 Mon Sep 17 00:00:00 2001 From: Aditya-354 Date: Fri, 5 Dec 2025 22:36:08 +0530 Subject: [PATCH 2/3] Replace incorrect sizeof-based loop with arr.size() in CONTRIBUTING.md example --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index bc2ed57dee..1bb1ff1767 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -97,7 +97,7 @@ assert(backtracking::subset_sum::number_of_subsets(0, array1) == */ template bool is_number_on_array(const std::vector &arr, const int &number) { - for (int i = 0; i < sizeof(arr) / sizeof(int); i++) { + for (int i = 0; i < arr.size(); i++) { if (arr[i] == number) { return true; } From a3803f14c75c2b6e801241b17b5cd9a303ae0d6c Mon Sep 17 00:00:00 2001 From: Aditya-354 Date: Fri, 5 Dec 2025 22:57:21 +0530 Subject: [PATCH 3/3] Replace incorrect sizeof-based loop with modern range-based loop in CONTRIBUTING.md example --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1bb1ff1767..78934b0438 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -97,8 +97,8 @@ assert(backtracking::subset_sum::number_of_subsets(0, array1) == */ template bool is_number_on_array(const std::vector &arr, const int &number) { - for (int i = 0; i < arr.size(); i++) { - if (arr[i] == number) { + for (const auto &x : arr) { + if (x == number) { return true; } else {