refactor: convert NULL to nullptr in debug message string literals

Update debug messages and string literals containing "NULL" to use
"nullptr" for consistency with code modernization.

Author: bobtista

Core/GameEngine/Include/Common/GameMemory.h

@@ -589,7 +589,7 @@ private: \
 			order-of-execution problem for static variables, ensuring this is not executed \
 			prior to the initialization of TheMemoryPoolFactory. \
 		*/ \
-		DEBUG_ASSERTCRASH(TheMemoryPoolFactory, ("TheMemoryPoolFactory is NULL")); \
+		DEBUG_ASSERTCRASH(TheMemoryPoolFactory, ("TheMemoryPoolFactory is nullptr")); \
 		static MemoryPool *The##ARGCLASS##Pool = TheMemoryPoolFactory->findMemoryPool(ARGPOOLNAME); \
 		DEBUG_ASSERTCRASH(The##ARGCLASS##Pool, ("Pool \"%s\" not found (did you set it up in initMemoryPools?)", ARGPOOLNAME)); \
 		DEBUG_ASSERTCRASH(The##ARGCLASS##Pool->getAllocationSize() >= sizeof(ARGCLASS), ("Pool \"%s\" is too small for this class (currently %d, need %d)", ARGPOOLNAME, The##ARGCLASS##Pool->getAllocationSize(), sizeof(ARGCLASS))); \
@@ -608,7 +608,7 @@ private: \
 			order-of-execution problem for static variables, ensuring this is not executed \
 			prior to the initialization of TheMemoryPoolFactory. \
 		*/ \
-		DEBUG_ASSERTCRASH(TheMemoryPoolFactory, ("TheMemoryPoolFactory is NULL")); \
+		DEBUG_ASSERTCRASH(TheMemoryPoolFactory, ("TheMemoryPoolFactory is nullptr")); \
 		static MemoryPool *The##ARGCLASS##Pool = TheMemoryPoolFactory->createMemoryPool(ARGPOOLNAME, sizeof(ARGCLASS), ARGINITIAL, ARGOVERFLOW); \
 		DEBUG_ASSERTCRASH(The##ARGCLASS##Pool, ("Pool \"%s\" not found (did you set it up in initMemoryPools?)", ARGPOOLNAME)); \
 		DEBUG_ASSERTCRASH(The##ARGCLASS##Pool->getAllocationSize() >= sizeof(ARGCLASS), ("Pool \"%s\" is too small for this class (currently %d, need %d)", ARGPOOLNAME, The##ARGCLASS##Pool->getAllocationSize(), sizeof(ARGCLASS))); \

Core/GameEngine/Include/GameNetwork/ConnectionManager.h

@@ -176,8 +176,8 @@ class ConnectionManager
 	void requestFrameDataResend(Int playerID, UnsignedInt frame); ///< request of this player that he send the specified frame's data.
 
 	// The connections are set up like the slot list. The connection corresponding to the local
-	// player's position in the slot list will be NULL.  Connections corresponding to slots that
-	// do not have a player will also be NULL.
+	// player's position in the slot list will be nullptr.  Connections corresponding to slots that
+	// do not have a player will also be nullptr.
 	Connection *m_connections[MAX_SLOTS];
 
 	Transport *m_transport;

Core/GameEngine/Source/Common/System/RAMFile.cpp

@@ -551,7 +551,7 @@ char* RAMFile::readEntireAndClose()
 
 	if (m_data == nullptr)
 	{
-		DEBUG_CRASH(("m_data is NULL in RAMFile::readEntireAndClose -- should not happen!"));
+		DEBUG_CRASH(("m_data is nullptr in RAMFile::readEntireAndClose -- should not happen!"));
 		return NEW char[1];	// just to avoid crashing...
 	}
 

Core/GameEngine/Source/Common/System/Radar.cpp

@@ -395,7 +395,7 @@ Bool Radar::addObject( Object *obj )
 
 	// sanity
 	DEBUG_ASSERTCRASH( obj->friend_getRadarData() == nullptr,
-										 ("Radar: addObject - non NULL radar data for '%s'",
+										 ("Radar: addObject - non nullptr radar data for '%s'",
 										 obj->getTemplate()->getName().str()) );
 
 	// allocate a new object
@@ -452,7 +452,7 @@ Bool Radar::deleteFromList( Object *obj, RadarObject **list )
 			else
 				prevObject->friend_setNext( radarObject->friend_getNext() );
 
-			// set the object radar data to NULL
+			// set the object radar data to nullptr
 			obj->friend_setRadarData( nullptr );
 
 			// delete the object instance
@@ -757,7 +757,7 @@ Object *Radar::searchListForRadarLocationMatch( RadarObject *listHead, ICoord2D
 		if( obj == nullptr )
 		{
 
-			DEBUG_CRASH(( "Radar::searchListForRadarLocationMatch - NULL object encountered in list" ));
+			DEBUG_CRASH(( "Radar::searchListForRadarLocationMatch - nullptr object encountered in list" ));
 			continue;
 
 		}
@@ -1318,12 +1318,12 @@ static void xferRadarObjectList( Xfer *xfer, RadarObject **head )
 			{
 				if (!radarObject->friend_getObject()->isDestroyed())
 				{
-					DEBUG_CRASH(( "xferRadarObjectList - List head should be NULL, or contain only destroyed objects" ));
+					DEBUG_CRASH(( "xferRadarObjectList - List head should be nullptr, or contain only destroyed objects" ));
 					throw SC_INVALID_DATA;
 				}
 			}
 #else
-			DEBUG_CRASH(( "xferRadarObjectList - List head should be NULL, but isn't" ));
+			DEBUG_CRASH(( "xferRadarObjectList - List head should be nullptr, but isn't" ));
 			throw SC_INVALID_DATA;
 #endif
 		}
@@ -1554,7 +1554,7 @@ void Radar::linkRadarObject( RadarObject *newObj, RadarObject **list )
 	RadarObject *prevObject;
 	RadarObject *nextObject;
 
-	DEBUG_ASSERTCRASH(newObj->friend_getNext() == nullptr, ("newObj->friend_getNext is not NULL"));
+	DEBUG_ASSERTCRASH(newObj->friend_getNext() == nullptr, ("newObj->friend_getNext is not nullptr"));
 
 	prevObject = nullptr;
 	prevPriority = RADAR_PRIORITY_INVALID;

Core/GameEngine/Source/Common/System/XferSave.cpp

@@ -83,7 +83,7 @@ XferSave::~XferSave( void )
 	{
 
 		// tell the user there is an error
-		DEBUG_CRASH(( "Warning: XferSave::~XferSave - m_blockStack was not NULL!" ));
+		DEBUG_CRASH(( "Warning: XferSave::~XferSave - m_blockStack was not nullptr!" ));
 
 		// delete the block stack
 		XferBlockData *next;
@@ -166,7 +166,7 @@ Int XferSave::beginBlock( void )
 {
 
 	// sanity
-	DEBUG_ASSERTCRASH( m_fileFP != nullptr, ("Xfer begin block - file pointer for '%s' is NULL",
+	DEBUG_ASSERTCRASH( m_fileFP != nullptr, ("Xfer begin block - file pointer for '%s' is nullptr",
 										 m_identifier.str()) );
 
 	// get the current file position so we can back up here for the next end block call
@@ -186,7 +186,7 @@ Int XferSave::beginBlock( void )
 	// save this block position on the top of the "stack"
 	XferBlockData *top = newInstance(XferBlockData);
 // impossible -- exception will be thrown (srj)
-//	if( top == NULL )
+//	if( top == nullptr )
 //	{
 //
 //		DEBUG_CRASH(( "XferSave - Begin block, out of memory - can't save block stack data" ));
@@ -211,7 +211,7 @@ void XferSave::endBlock( void )
 {
 
 	// sanity
-	DEBUG_ASSERTCRASH( m_fileFP != nullptr, ("Xfer end block - file pointer for '%s' is NULL",
+	DEBUG_ASSERTCRASH( m_fileFP != nullptr, ("Xfer end block - file pointer for '%s' is nullptr",
 										 m_identifier.str()) );
 
 	// sanity, make sure we have a block started
@@ -258,7 +258,7 @@ void XferSave::skip( Int dataSize )
 {
 
 	// sanity
-	DEBUG_ASSERTCRASH( m_fileFP != nullptr, ("XferSave - file pointer for '%s' is NULL",
+	DEBUG_ASSERTCRASH( m_fileFP != nullptr, ("XferSave - file pointer for '%s' is nullptr",
 										 m_identifier.str()) );
 
 
@@ -343,7 +343,7 @@ void XferSave::xferImplementation( void *data, Int dataSize )
 {
 
 	// sanity
-	DEBUG_ASSERTCRASH( m_fileFP != nullptr, ("XferSave - file pointer for '%s' is NULL",
+	DEBUG_ASSERTCRASH( m_fileFP != nullptr, ("XferSave - file pointer for '%s' is nullptr",
 										 m_identifier.str()) );
 
 	// write data to file

Core/GameEngine/Source/GameNetwork/ConnectionManager.cpp

@@ -1091,7 +1091,7 @@ void ConnectionManager::ackCommand(NetCommandRef *ref, UnsignedInt localSlot) {
 //						DEBUG_LOG(("ConnectionManager::ackCommand - acking command %d from player %d directly to player.", commandID, msg->getPlayerID()));
 						m_connections[msg->getPlayerID()]->sendNetCommandMsg(ackmsg, 1 << msg->getPlayerID());
 					} else {
-	//					DEBUG_ASSERTCRASH(m_connections[msg->getPlayerID()] != NULL, ("Connection to player is nullptr"));
+	//					DEBUG_ASSERTCRASH(m_connections[msg->getPlayerID()] != nullptr, ("Connection to player is nullptr"));
 					}
 				} else {
 					DEBUG_ASSERTCRASH((msg->getPlayerID() >= 0) && (msg->getPlayerID() < MAX_SLOTS), ("Command sent by an invalid player ID."));

Core/GameEngine/Source/GameNetwork/FirewallHelper.cpp

@@ -424,7 +424,7 @@ UnsignedShort FirewallHelperClass::getManglerResponse(UnsignedShort packetID, In
 {
 	ManglerMessage *msg = nullptr;
 
-//	SpareSocketStruct *spareSocket = NULL;
+//	SpareSocketStruct *spareSocket = nullptr;
 
 	sockaddr_in addr;
 

Core/GameEngine/Source/GameNetwork/GameSpy/Thread/PeerThread.cpp

@@ -2975,7 +2975,7 @@ static void listingGamesCallback(PEER peer, PEERBool success, const char * name,
 			resp.stagingServerName = MultiByteToWideCharSingleLine( gameName.str() );
 			DEBUG_LOG(("Server had basic=%d, full=%d", SBServerHasBasicKeys(server), SBServerHasFullKeys(server)));
 #ifdef DEBUG_LOGGING
-			//SBServerEnumKeys(server, enumFunc, NULL);
+			//SBServerEnumKeys(server, enumFunc, nullptr);
 #endif
 			break;
 		case PEER_REMOVE:

Core/GameEngineDevice/Source/W3DDevice/GameClient/Water/W3DWater.cpp

@@ -1108,7 +1108,7 @@ Int WaterRenderObjClass::init(Real waterLevel, Real dx, Real dy, SceneClass *par
 
 	m_riverTexture=WW3DAssetManager::Get_Instance()->Get_Texture(TheWaterTransparency->m_standingWaterTexture.str());
 
-	//For some reason setting a NULL texture does not result in 0xffffffff for pixel shaders so using explicit "white" texture.
+	//For some reason setting a nullptr texture does not result in 0xffffffff for pixel shaders so using explicit "white" texture.
 	m_whiteTexture=MSGNEW("TextureClass") TextureClass(1,1,WW3D_FORMAT_A4R4G4B4,MIP_LEVELS_1);
 	SurfaceClass *surface=m_whiteTexture->Get_Surface_Level();
 	surface->DrawPixel(0,0,0xffffffff);
@@ -1349,7 +1349,7 @@ void WaterRenderObjClass::loadSetting( Setting *setting, TimeOfDay timeOfDay )
 	SurfaceClass::SurfaceDescription surfaceDesc;
 
 	// sanity
-	DEBUG_ASSERTCRASH( setting, ("WaterRenderObjClass::loadSetting, NULL setting") );
+	DEBUG_ASSERTCRASH( setting, ("WaterRenderObjClass::loadSetting, nullptr setting") );
 
 	// textures
 	setting->skyTexture = WW3DAssetManager::Get_Instance()->Get_Texture( WaterSettings[ timeOfDay ].m_skyTextureFile.str() );
@@ -1717,7 +1717,7 @@ void WaterRenderObjClass::Render(RenderInfoClass & rinfo)
 	}
 
 	//Clean up after any pixel shaders.
-	//Force render state apply so that the "nullptr" texture gets applied to D3D, thus releasing shroud reference count.
+	//Force render state apply so that the "NULL" texture gets applied to D3D, thus releasing shroud reference count.
 	DX8Wrapper::Apply_Render_State_Changes();
 	DX8Wrapper::Invalidate_Cached_Render_States();
 
@@ -2625,7 +2625,7 @@ void WaterRenderObjClass::setGridResolution(Real gridCellsX, Real gridCellsY, Re
 		{
 
 			delete [] m_meshData;//free previously allocated grid and allocate new size
-			m_meshData = nullptr;	 // must set to NULL so that we properly re-allocate
+			m_meshData = nullptr;	 // must set to nullptr so that we properly re-allocate
 			m_meshDataSize = 0;
 
 			Bool enable = m_doWaterGrid;
@@ -2956,7 +2956,7 @@ void WaterRenderObjClass::setupFlatWaterShader(void)
 			DX8Wrapper::_Get_D3D_Device8()->SetRenderState(D3DRS_ZFUNC, D3DCMP_LESSEQUAL);
 		}
 		else
-		{	//Assume no shroud, so stage 3 will be "nullptr" texture but using actual white because
+		{	//Assume no shroud, so stage 3 will be "NULL" texture but using actual white because
 			//pixel shader on GF4 generates random colors with SetTexture(3,nullptr).
 			if (!m_whiteTexture->Is_Initialized())
 			{	m_whiteTexture->Init();

Core/Libraries/Source/WWVegas/WW3D2/composite.cpp

@@ -206,9 +206,9 @@ void CompositeRenderObjClass::Set_Name(const char * name)
  *=============================================================================================*/
 void CompositeRenderObjClass::Set_Base_Model_Name(const char *name)
 {
-	// NULL is a legal value for BaseModelName. Unfortunately,
+	// nullptr is a legal value for BaseModelName. Unfortunately,
 	// StringClass::operator= does not modify the string when
-	// assigning NULL, so we explicitly handle that case here.
+	// assigning nullptr, so we explicitly handle that case here.
 	if (name != nullptr) {
 		BaseModelName = name;
 	} else {