refactor(clang-tidy): fix remaining bugprone-suspicious-string-compare instances

Author: bobtista

Core/Libraries/Source/WWVegas/WW3D2/texturethumbnail.cpp

@@ -37,7 +37,7 @@ static void Create_Hash_Name(StringClass& name, const StringClass& thumb_name)
 {
 	name=thumb_name;
 	int len=name.Get_Length();
-	WWASSERT(!stricmp(&name[len-4],".tga") || !stricmp(&name[len-4],".dds"));
+	WWASSERT(stricmp(&name[len-4],".tga") == 0 || stricmp(&name[len-4],".dds") == 0);
 	name[len-4]='\0';
 	_strlwr(name.Peek_Buffer());
 }

Core/Tools/Autorun/GameText.cpp

@@ -778,7 +778,7 @@ Bool GameTextManager::getStringCount( char *filename )
 				m_buffer[ len+1] = 0;
 			readToEndOfQuote( &file, &m_buffer[1], m_buffer2, m_buffer3, MAX_UITEXT_LENGTH );
 		}
-		else if( !stricmp( m_buffer, "END") )
+		else if( stricmp( m_buffer, "END") == 0 )
 		{
 			m_textCount++;
 		}
@@ -974,7 +974,7 @@ Bool GameTextManager::parseStringFile( char *filename )
 
 		for ( Int i = 0; i < listCount; i++ )
 		{
-			if ( !stricmp ( m_stringInfo[i].label.c_str(), m_buffer ))
+			if ( stricmp ( m_stringInfo[i].label.c_str(), m_buffer ) == 0 )
 			{
 				DEBUG_ASSERTCRASH ( FALSE, ("String label '%s' multiply defined!", m_buffer ));
 			}
@@ -1025,7 +1025,7 @@ Bool GameTextManager::parseStringFile( char *filename )
 					readString = TRUE;
 				}
 			}
-			else if ( !stricmp ( m_buffer, "END" ))
+			else if ( stricmp ( m_buffer, "END" ) == 0 )
 			{
 				break;
 			}

Core/Tools/Compress/Compress.cpp

@@ -58,13 +58,13 @@ int main(int argc, char **argv)
 
 	for (int i=1; i<argc; ++i)
 	{
-		if ( !stricmp(argv[i], "-help") )
+		if ( stricmp(argv[i], "-help") == 0 )
 		{
 			dumpHelp(argv[0]);
 			return EXIT_SUCCESS;
 		}
 
-		if ( !strcmp(argv[i], "-in") )
+		if ( strcmp(argv[i], "-in") == 0 )
 		{
 			++i;
 			if (i<argc)
@@ -73,7 +73,7 @@ int main(int argc, char **argv)
 			}
 		}
 
-		if ( !strcmp(argv[i], "-out") )
+		if ( strcmp(argv[i], "-out") == 0 )
 		{
 			++i;
 			if (i<argc)
@@ -82,14 +82,14 @@ int main(int argc, char **argv)
 			}
 		}
 
-		if ( !strcmp(argv[i], "-type") )
+		if ( strcmp(argv[i], "-type") == 0 )
 		{
 			++i;
 			if (i<argc)
 			{
 				for (int j=COMPRESSION_MIN; j<=COMPRESSION_MAX; ++j)
 				{
-					if ( !stricmp(CompressionManager::getCompressionNameByType((CompressionType)j), argv[i]) )
+					if ( stricmp(CompressionManager::getCompressionNameByType((CompressionType)j), argv[i]) == 0 )
 					{
 						compressType = (CompressionType)j;
 						break;

Core/Tools/W3DView/W3DView.cpp

@@ -344,7 +344,7 @@ void Debug_Refs(void)
 			ActiveRefStruct * search_ref = &(search_obj->ActiveRefInfo);
 
 			if ( ref->File && search_ref->File &&
-				  !strcmp(search_ref->File, ref->File) &&
+				  strcmp(search_ref->File, ref->File) == 0 &&
 				  (search_ref->Line == ref->Line) ) {
 				count++;
 			} else if ( (ref->File == NULL) &&  (search_ref->File == NULL) ) {