refactor: use container.empty() instead of container.size() == 0 #1957
+109
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dability-container-size-empty)
bobtista
force-pushed
the
bobtista/refactor/clang-tidy-container-empty
branch
from
d87241f to
9174538
Compare
bobtista
added
Minor
xezon
reviewed
Dec 7, 2025
xezon
left a comment
xezon
left a comment
There was a problem hiding this comment.
Nice improvement. With std::list from STLPort this can give small performance gains too.
| m_playerColors[i] = 0; | ||
| } | ||
| if (incomingRequest.password.length() > 0) | ||
| if (!incomingRequest.password.empty()) |
There was a problem hiding this comment.
I suspect clang-tidy only finds std:: related cases, unless it can be configured for other types?
We still need the same kind of change for AsciiString and other internal types (in another change).
Author
There was a problem hiding this comment.
I got this plugin working for AsciiString and UnicodeString clang-tidy-plugin
Are there others?
There was a problem hiding this comment.
There are string classes in WWVegas too.
Search for wwstring.h (there are multiple)
xezon
approved these changes
Dec 9, 2025
|
Is this change complete or is it still missing checks from files it previously failed on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran clang-tidy (readability-container-size-empty))