refactor: extract upload validation and add test cases

Author: streamtw

src/Controllers/CropController.php

@@ -47,7 +47,7 @@ public function getCropimage($overWrite = true)
             ->save($crop_path);
 
         // make new thumbnail
-        $this->lfm->makeThumbnail($image_name);
+        $this->lfm->generateThumbnail($image_name);
 
         event(new ImageWasCropped($image_path));
     }

src/Controllers/LfmController.php

@@ -71,11 +71,6 @@ public function getErrors()
         return $arr_errors;
     }
 
-    public function error($error_type, $variables = [])
-    {
-        return $this->helper->error($error_type, $variables);
-    }
-
     /**
      * Overrides settings in php.ini.
      *

src/Controllers/UploadController.php

@@ -33,6 +33,8 @@ public function upload()
 
         foreach (is_array($uploaded_files) ? $uploaded_files : [$uploaded_files] as $file) {
             try {
+                $this->lfm->validateUploadedFile($file);
+
                 $new_filename = $this->lfm->upload($file);
             } catch (\Exception $e) {
                 Log::error($e->getMessage(), [

src/Exceptions/DuplicateFileNameException.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace UniSharp\LaravelFilemanager\Exceptions;
+
+class DuplicateFileNameException extends \Exception
+{
+    public function __construct()
+    {
+        $this->message = trans('laravel-filemanager::lfm.error-file-exist');
+    }
+}

src/Exceptions/EmptyFileException.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace UniSharp\LaravelFilemanager\Exceptions;
+
+class EmptyFileException extends \Exception
+{
+    public function __construct()
+    {
+        $this->message = trans('laravel-filemanager::lfm.error-file-empty');
+    }
+}

src/Exceptions/ExcutableFileException.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace UniSharp\LaravelFilemanager\Exceptions;
+
+class ExcutableFileException extends \Exception
+{
+    public function __construct()
+    {
+        $this->message = 'Invalid file detected';
+    }
+}

src/Exceptions/FileFailedToUploadException.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace UniSharp\LaravelFilemanager\Exceptions;
+
+class FileFailedToUploadException extends \Exception
+{
+    public function __construct($error_code)
+    {
+        $this->message = 'File failed to upload. Error code: ' . $error_code;
+    }
+}

src/Exceptions/FileSizeExceedConfigurationMaximumException.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace UniSharp\LaravelFilemanager\Exceptions;
+
+class FileSizeExceedConfigurationMaximumException extends \Exception
+{
+    public function __construct($file_size)
+    {
+        $this->message = trans('laravel-filemanager::lfm.error-size') . $file_size;
+    }
+}

src/Exceptions/FileSizeExceedIniMaximumException.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace UniSharp\LaravelFilemanager\Exceptions;
+
+class FileSizeExceedIniMaximumException extends \Exception
+{
+    public function __construct()
+    {
+        $this->message = trans('laravel-filemanager::lfm.error-file-size', ['max' => ini_get('upload_max_filesize')]);
+    }
+}

src/Exceptions/InvalidMimeTypeException.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace UniSharp\LaravelFilemanager\Exceptions;
+
+class InvalidMimeTypeException extends \Exception
+{
+    public function __construct($mimetype)
+    {
+        $this->message = trans('laravel-filemanager::lfm.error-mime') . $mimetype;
+    }
+}