Removed legacy RSA code and expanded on XML comments for EncryptionBuffer

Author: TwoTenPvP

MLAPI/Data/NetworkConfig.cs

@@ -64,11 +64,15 @@ public class NetworkConfig
         [HideInInspector]
         internal string PlayerPrefabName;
         /// <summary>
-        /// The size of the receive message buffer. This is the max message size.
+        /// The size of the receive message buffer. This is the max message size including any MLAPI overheads.
         /// </summary>
         public int MessageBufferSize = 1024;
         /// <summary>
         /// The size of the encryption buffer, this is the buffer where messages will be decrypted to.
+        /// If you plan on encrypting everything and you are pushing limits wth the MessageBufferSize already.
+        /// Note that Encryption might add a few extra bytes of padding and 16 bytes for the IV, if authentication is also enabled
+        /// 32 extra bytes will be used for the SHA256 hash of the HMAC.
+        /// Note that authentication without encryption will not use this buffer at all.
         /// </summary>
         public int EncryptionBufferSize = 265;
         /// <summary>

MLAPI/MonoBehaviours/Core/NetworkingManager.cs

@@ -147,6 +147,7 @@ internal set
         /// </summary>
         public event CustomMessageDelegete OnIncommingCustomMessage;
         public string ConnectedHostname { get; private set; }
+        internal byte[] clientAesKey;
         internal static event Action OnSingletonReady;
 
         internal void InvokeOnIncommingCustomMessage(uint clientId, Stream stream)
@@ -194,13 +195,6 @@ public void SendCustomMessage(uint clientId, Stream stream, string channel = "ML
             InternalMessageHandler.Send(clientId, MLAPIConstants.MLAPI_CUSTOM_MESSAGE, channel, stream, SecuritySendFlags.None);
         }
 
-        internal byte[] clientAesKey;
-
-        /// <summary>
-        /// An inspector bool that acts as a Trigger for regenerating RSA keys. Should not be used outside Unity editor.
-        /// </summary>
-        public bool RegenerateRSAKeys = false;
-
         private void OnValidate()
         {
             if (NetworkConfig == null)
@@ -244,30 +238,7 @@ private void OnValidate()
                     if (LogHelper.CurrentLogLevel <= LogLevel.Normal) LogHelper.LogWarning("Only one networked prefab can be marked as a player prefab");
                 }
                 else NetworkConfig.PlayerPrefabName = NetworkConfig.NetworkedPrefabs.Find(x => x.playerPrefab == true).name;
-
-            }
-
-            /*
-            if (!NetworkConfig.EnableEncryption)
-            {
-                RegenerateRSAKeys = false;
-            }
-            else
-            {
-                if (RegenerateRSAKeys)
-                {
-#if !DISABLE_CRYPTOGRAPHY
-                    using (RSACryptoServiceProvider rsa = new RSACryptoServiceProvider())
-                    {
-                        rsa.PersistKeyInCsp = false;
-                        NetworkConfig.RSAPrivateKey = rsa.ToXmlString(true);
-                        NetworkConfig.RSAPublicKey = rsa.ToXmlString(false);
-                    }
-#endif
-                    RegenerateRSAKeys = false;
-                }
             }
-            */
         }
 
         private object Init(bool server)