✨ Add warning about == and !=

Author: Vincent Langlet

Symfony3Custom/Sniffs/Formatting/StrictComparisonSniff.php

@@ -0,0 +1,55 @@
+<?php
+
+/**
+ * Throws warning if == or != are use
+ */
+class Symfony3Custom_Sniffs_Formatting_StrictComparisonSniff implements PHP_CodeSniffer_Sniff
+{
+    /**
+     * Types to replace: key is operator to replace, value is operator to replace with.
+     *
+     * @var array
+     */
+    public $operators = array(
+        'T_IS_EQUAL'     => '===',
+        'T_IS_NOT_EQUAL' => '!==',
+    );
+
+    /**
+     * A list of tokenizers this sniff supports.
+     *
+     * @return array
+     */
+    public function register()
+    {
+        return array(
+            T_IS_EQUAL,
+            T_IS_NOT_EQUAL,
+        );
+    }
+
+    /**
+     * Processes this test, when one of its tokens is encountered.
+     *
+     * @param PHP_CodeSniffer_File $phpcsFile All the tokens found in the document.
+     * @param int                  $stackPtr  The position of the current token in
+     *                                        the stack passed in $tokens.
+     *
+     * @return void
+     */
+    public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
+    {
+        $tokens = $phpcsFile->getTokens();
+
+        // This warning is fixable, but it's too dangerous to add automatically fixer
+        $phpcsFile->addWarning(
+            'The %s comparator is not recommended, use %s instead',
+            $stackPtr,
+            '',
+            array(
+                $tokens[$stackPtr]['content'],
+                $this->operators[$tokens[$stackPtr]['type']],
+            )
+        );
+    }
+}

Symfony3Custom/Tests/Formatting/StrictComparisonUnitTest.inc

@@ -0,0 +1,9 @@
+<?php
+
+if ($true == true) {
+    echo 'True';
+} elseif ($true != true) {
+    echo 'False';
+} elseif (false === $true && true !== $false) {
+    echo 'False';
+}

Symfony3Custom/Tests/Formatting/StrictComparisonUnitTest.php

@@ -0,0 +1,33 @@
+<?php
+
+/**
+ * Unit test class for the StrictComparison sniff.
+ *
+ * A sniff unit test checks a .inc file for expected violations of a single
+ * coding standard. Expected errors and warnings are stored in this class.
+ */
+class Symfony3Custom_Tests_Formatting_StrictComparisonUnitTest extends AbstractSniffUnitTest
+{
+    /**
+     * Returns the lines where errors should occur.
+     *
+     * @return array <int line number> => <int number of errors>
+     */
+    public function getErrorList()
+    {
+        return array();
+    }
+
+    /**
+     * Returns the lines where warnings should occur.
+     *
+     * @return array <int line number> => <int number of warnings>
+     */
+    public function getWarningList()
+    {
+        return array(
+            3 => 1,
+            5 => 1,
+        );
+    }
+}