Merge pull request #18 from VincentLanglet/staging

✨ Do not require space for concatenation

Author: VincentLanglet

Symfony3Custom/Sniffs/Commenting/DocCommentGroupSameTypeSniff.php

@@ -99,14 +99,14 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
                         if ($previousType === $currentType) {
                             $fix = $phpcsFile->addFixableError(
                                 'Expected no empty lines '
-                                . 'between annotations of the same type',
+                                .'between annotations of the same type',
                                 $commentTag,
                                 'SameType'
                             );
                         } else {
                             $fix = $phpcsFile->addFixableError(
                                 'Expected no empty lines '
-                                . 'between custom annotations',
+                                .'between custom annotations',
                                 $commentTag,
                                 'CustomType'
                             );
@@ -127,7 +127,7 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
                     if ($previousLine !== $commentTagLine - 2) {
                         $fix = $phpcsFile->addFixableError(
                             'Expected exactly one empty line '
-                            . 'between annotations of different types',
+                            .'between annotations of different types',
                             $commentTag,
                             'DifferentType'
                         );
@@ -151,7 +151,7 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
                                 );
                                 $phpcsFile->fixer->addContentBefore(
                                     $firstOnLine,
-                                    $content . $phpcsFile->eolChar
+                                    $content.$phpcsFile->eolChar
                                 );
                             } else {
                                 $this->removeLines(

Symfony3Custom/Sniffs/Functions/ScopeOrderSniff.php

@@ -76,7 +76,7 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
                     $current = $current[0];
 
                     $error = 'Declare public methods first,'
-                    . 'then protected ones and finally private ones';
+                    .'then protected ones and finally private ones';
 
                     if (isset($previous) && $current < $previous) {
                         $phpcsFile->addError(

Symfony3Custom/ruleset.xml

@@ -50,7 +50,6 @@
         <!-- From endouble repo -->
         <rule ref="Squiz.Strings.ConcatenationSpacing">
             <properties>
-                <property name="spacing" value="1"/>
                 <property name="ignoreNewlines" value="true" />
             </properties>
         </rule>

docs/standards.md

@@ -25,9 +25,8 @@ We imported the [PSR2 Standard](./psr2.md) with this override:
 
 We mainly respect the [Symfony Standard](./symfony.md) but
 
-- We do not respect these rules:
+- We do not respect this rule:
 
-  - Add no space around the concatenation (`.`) operator
   - Declare all the arguments on the same line as the method/function name, no matter how many arguments there are
 
 - We do not currently check these rules:

docs/standards/symfony.md

@@ -9,16 +9,12 @@ From [symfony standard](http://symfony.com/doc/current/contributing/code/standar
 ```
 
 - Add a single space around binary operators (`==`, `&&`, `...`)
+ with the exception of the concatenation (`.`) operator
 
 ```
 <rule ref="Squiz.WhiteSpace.OperatorSpacing" />
-```
-
-We do not respect the exception of the concatenation (`.`) operator
-```
 <rule ref="Squiz.Strings.ConcatenationSpacing">
     <properties>
-        <property name="spacing" value="1"/>
         <property name="ignoreNewlines" value="true" />
     </properties>
 </rule>