✨ Clean rules, add some and update doc

Author: Vincent Langlet

Symfony3Custom/Sniffs/WhiteSpace/CommaSpacingSniff.php

@@ -35,27 +35,19 @@
     <!-- ***  OTHERS  *** -->
     <!-- **************** -->
 
-        <!-- Complete with some of ZEND standard -->
-        <rule ref="Generic.Functions.OpeningFunctionBraceBsdAllman">
-            <exclude name="Generic.Functions.OpeningFunctionBraceBsdAllman.BraceOnSameLine"/>
-        </rule>
+        <!-- From djoos repo -->
         <rule ref="Generic.PHP.DisallowShortOpenTag"/>
-        <rule ref="PEAR.Classes.ClassDeclaration"/>
-        <rule ref="Squiz.Functions.GlobalFunction"/>
         <rule ref="Squiz.NamingConventions.ValidVariableName">
             <exclude name="Squiz.NamingConventions.ValidVariableName.PrivateNoUnderscore"/>
             <exclude name="Squiz.NamingConventions.ValidVariableName.ContainsNumbers"/>
         </rule>
-
-        <!-- Rules added by djoos/Symfony2-coding-standard-->
         <rule ref="Generic.Formatting.SpaceAfterCast"/>
-        <rule ref="Generic.Functions.CallTimePassByReference"/>
         <rule ref="Squiz.Arrays.ArrayBracketSpacing"/>
         <rule ref="Squiz.PHP.LowercasePHPFunctions"/>
         <rule ref="Squiz.Scope.MemberVarScope"/>
         <rule ref="PEAR.Commenting.InlineComment"/>
 
-        <!-- Rules added by endouble/Symfony3Custom-coding-standard -->
+        <!-- From endouble repo -->
         <rule ref="Squiz.Strings.ConcatenationSpacing">
             <properties>
                 <property name="spacing" value="1"/>
@@ -66,10 +58,14 @@
             <severity>0</severity>
         </rule>
 
-        <!-- Rules added by VincentLanglet/Symfony3Custom-coding-standard -->
+        <!-- Added by VincentLanglet repo -->
+        <rule ref="Squiz.Classes.ClassFileName"/>
+        <rule ref="Squiz.Strings.DoubleQuoteUsage"/>
+        <rule ref="Squiz.WhiteSpace.FunctionOpeningBraceSpace"/>
         <rule ref="Squiz.WhiteSpace.OperatorSpacing">
             <properties>
                 <property name="ignoreNewlines" value="true"/>
             </properties>
         </rule>
+        <rule ref="Squiz.WhiteSpace.SemicolonSpacing"/>
 </ruleset>

Symfony3Custom/Tests/WhiteSpace/CommaSpacingUnitTest.inc

@@ -39,91 +39,84 @@ We mainly respect the [Symfony Standard](./symfony.md) but
   - Do not use `else`, `elseif`, `break` after `if` and `case` conditions which return or throw something
 
 ## Others
-### From Zend
-
-- @TODO
+### Imported
+- Do not use `<?` to define a php file
 
 ```
-<rule ref="Generic.Functions.OpeningFunctionBraceBsdAllman">
-    <exclude name="Generic.Functions.OpeningFunctionBraceBsdAllman.BraceOnSameLine"/>
-</rule>
+<rule ref="Generic.PHP.DisallowShortOpenTag"/>
 ```
 
-- @TODO
+- Add a single space after type casting
 
 ```
-<rule ref="Generic.PHP.DisallowShortOpenTag"/>
+<rule ref="Generic.Formatting.SpaceAfterCast"/>
 ```
 
-- @TODO
+- Use lowercase for PHP functions
 
 ```
-<rule ref="PEAR.Classes.ClassDeclaration"/>
+<rule ref="Squiz.PHP.LowercasePHPFunctions"/>
 ```
 
-- @TODO
+- Variable have scope modifier
 
 ```
-<rule ref="Squiz.Functions.GlobalFunction"/>
+<rule ref="Squiz.Scope.MemberVarScope"/>
+<rule ref="Symfony3Custom.Scope.MethodScope"/>
 ```
 
-- @TODO
+- No perl-style comments are used
 
 ```
-<rule ref="Squiz.NamingConventions.ValidVariableName">
-    <exclude name="Squiz.NamingConventions.ValidVariableName.PrivateNoUnderscore"/>
-    <exclude name="Squiz.NamingConventions.ValidVariableName.ContainsNumbers"/>
-</rule>
+<rule ref="PEAR.Commenting.InlineComment"/>
 ```
 
-### Others
-
-- Add a single space after type casting
+- Use same name for a file and the class inside
 
 ```
-<rule ref="Generic.Formatting.SpaceAfterCast"/>
+<rule ref="Squiz.Classes.ClassFileName"/>
 ```
 
-- Add a single space around assignement operator
+- Use single quotes instead of double quotes
 
 ```
-<rule ref="Symfony3Custom.WhiteSpace.AssignementSpacing"/>
+<rule ref="Squiz.Strings.DoubleQuoteUsage"/>
 ```
 
-- Do not use spaces after `(` or `{` or before `)` or `}`
+- Do not skip blank line after function opening brace
 
 ```
-<rule ref="Symfony3Custom.WhiteSpace.CloseBracketSpacing"/>
-<rule ref="Symfony3Custom.WhiteSpace.OpenBracketSpacing"/>
+<rule ref="Squiz.WhiteSpace.FunctionOpeningBraceSpace"/>
 ```
 
-- Do not use multiple following blank lines
+- Do not use space before semicolon
 
 ```
-<rule ref="Symfony3Custom.WhiteSpace.EmptyLines"/>
+<rule ref="Squiz.WhiteSpace.SemicolonSpacing"/>
 ```
 
-- Do not call functions with variables passed by reference
+### Custom
+- Some others checks are made about array (`=>` alignments and indentation)
 
 ```
-<rule ref="Generic.Functions.CallTimePassByReference"/>
+<rule ref="Symfony3Custom.Array.ArrayDeclaration"/>
 ```
 
-- Use lowercase for PHP functions
+- Do not use spaces after `(` or `{` and before `)` or `}`
 
 ```
-<rule ref="Squiz.PHP.LowercasePHPFunctions"/>
+<rule ref="Symfony3Custom.WhiteSpace.CloseBracketSpacing"/>
+<rule ref="Symfony3Custom.WhiteSpace.OpenBracketSpacing"/>
 ```
 
-- Variable and methods have scope modifier
+- Do not use multiple following blank lines
 
 ```
-<rule ref="Squiz.Scope.MemberVarScope"/>
-<rule ref="Symfony3Custom.Scope.MethodScope"/>
+<rule ref="Symfony3Custom.WhiteSpace.EmptyLines"/>
 ```
 
-- No perl-style comments are used
+- Methods have scope modifier
 
 ```
-<rule ref="PEAR.Commenting.InlineComment"/>
+<rule ref="Symfony3Custom.Scope.MethodScope"/>
 ```

Symfony3Custom/Tests/WhiteSpace/CommaSpacingUnitTest.inc.fixed

@@ -5,13 +5,13 @@ From [symfony standard](http://symfony.com/doc/current/contributing/code/standar
 - Add a single space after each comma delimiter
 
 ```
-<rule ref="Symfony3Custom.WhiteSpace.CommaSpacing" />
+<rule ref="Symfony3Custom.Array.ArrayDeclaration" />
 ```
 
 - Add a single space around binary operators (`==`, `&&`, `...`)
 
 ```
-<rule ref="Symfony3Custom.WhiteSpace.BinaryOperatorSpacing" />
+<rule ref="Squiz.WhiteSpace.OperatorSpacing" />
 ```
 
 We do not respect the exception of the concatenation (`.`) operator
@@ -116,11 +116,17 @@ Not covered
 
 - Use camelCase, not underscores, for variable, function and method names, arguments
 
-Covered by `PSR2` and `Zend`
+Covered by `PSR2` completed by
+```
+<rule ref="Squiz.NamingConventions.ValidVariableName">
+    <exclude name="Squiz.NamingConventions.ValidVariableName.PrivateNoUnderscore"/>
+    <exclude name="Squiz.NamingConventions.ValidVariableName.ContainsNumbers"/>
+</rule>
+```
 
 - Use namespaces for all classes
 
-Covered by `PSR1`
+Covered by `PSR1` completed by
 ```
 <rule ref="Squiz.Classes.ValidClassName" />
 ```