Skip to content

Commit 5b8234c

Browse files
committed
update method of disabling KLib targets in tests
1 parent a561c21 commit 5b8234c

File tree

1 file changed

+64
-17
lines changed

1 file changed

+64
-17
lines changed

modules/bcv-gradle-plugin-functional-tests/src/functionalTest/kotlin/kotlinx/validation/test/KlibVerificationTests.kt

Lines changed: 64 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,6 @@ internal class KlibVerificationTests : BaseKotlinGradleTest() {
215215
}
216216
}
217217

218-
219218
runner.build {
220219
checkKLibDump("/examples/classes/HiddenDeclarations.klib.dump")
221220
}
@@ -323,8 +322,9 @@ internal class KlibVerificationTests : BaseKotlinGradleTest() {
323322
abiFile(projectName = "testproject") {
324323
resolve("/examples/classes/TopLevelDeclarations.klib.dump")
325324
}
325+
disableKLibTargets("linuxArm64")
326326
runner {
327-
arguments.add("-P$BANNED_TARGETS_PROPERTY_NAME=linuxArm64")
327+
// arguments.add("-P$BANNED_TARGETS_PROPERTY_NAME=linuxArm64")
328328
arguments.add(":apiCheck")
329329
}
330330
}
@@ -343,8 +343,10 @@ internal class KlibVerificationTests : BaseKotlinGradleTest() {
343343
// note that the regular dump is used, where linuxArm64 is presented
344344
resolve("/examples/classes/TopLevelDeclarations.klib.dump")
345345
}
346+
disableKLibTargets("linuxArm64")
347+
346348
runner {
347-
arguments.add("-P$BANNED_TARGETS_PROPERTY_NAME=linuxArm64")
349+
// arguments.add("-P$BANNED_TARGETS_PROPERTY_NAME=linuxArm64")
348350
arguments.add(":apiCheck")
349351
}
350352
}
@@ -364,8 +366,11 @@ internal class KlibVerificationTests : BaseKotlinGradleTest() {
364366
// note that the regular dump is used, where linuxArm64 is presented
365367
resolve("/examples/classes/TopLevelDeclarations.klib.dump")
366368
}
369+
370+
disableKLibTargets("linuxArm64")
371+
367372
runner {
368-
arguments.add("-P$BANNED_TARGETS_PROPERTY_NAME=linuxArm64")
373+
// arguments.add("-P$BANNED_TARGETS_PROPERTY_NAME=linuxArm64")
369374
arguments.add(":apiCheck")
370375
}
371376
}
@@ -381,8 +386,11 @@ internal class KlibVerificationTests : BaseKotlinGradleTest() {
381386
baseProjectSetting()
382387
addToSrcSet("/examples/classes/TopLevelDeclarations.kt")
383388
addToSrcSet("/examples/classes/AnotherBuildConfigLinuxArm64.kt", "linuxArm64Main")
389+
390+
disableKLibTargets("linuxArm64")
391+
384392
runner {
385-
arguments.add("-P$BANNED_TARGETS_PROPERTY_NAME=linuxArm64")
393+
// arguments.add("-P$BANNED_TARGETS_PROPERTY_NAME=linuxArm64")
386394
arguments.add(":apiDump")
387395
}
388396
}
@@ -406,8 +414,11 @@ internal class KlibVerificationTests : BaseKotlinGradleTest() {
406414
additionalBuildConfig("/examples/gradle/configuration/grouping/clashingTargetNames.gradle.kts")
407415
addToSrcSet("/examples/classes/TopLevelDeclarations.kt")
408416
addToSrcSet("/examples/classes/AnotherBuildConfigLinuxArm64.kt", "linuxMain")
417+
418+
disableKLibTargets("linux")
419+
409420
runner {
410-
arguments.add("-P$BANNED_TARGETS_PROPERTY_NAME=linux")
421+
// arguments.add("-P$BANNED_TARGETS_PROPERTY_NAME=linux")
411422
arguments.add(":klibApiDump")
412423
}
413424
}
@@ -430,8 +441,11 @@ internal class KlibVerificationTests : BaseKotlinGradleTest() {
430441
}
431442
addToSrcSet("/examples/classes/TopLevelDeclarations.kt")
432443
addToSrcSet("/examples/classes/AnotherBuildConfigLinuxArm64.kt", "linuxArm64Main")
444+
445+
disableKLibTargets("linuxArm64")
446+
433447
runner {
434-
arguments.add("-P$BANNED_TARGETS_PROPERTY_NAME=linuxArm64")
448+
// arguments.add("-P$BANNED_TARGETS_PROPERTY_NAME=linuxArm64")
435449
arguments.add(":klibApiDump")
436450
}
437451
}
@@ -447,11 +461,20 @@ internal class KlibVerificationTests : BaseKotlinGradleTest() {
447461
val runner = test {
448462
baseProjectSetting()
449463
addToSrcSet("/examples/classes/TopLevelDeclarations.kt")
464+
disableKLibTargets(
465+
"linuxArm64",
466+
"linuxX64",
467+
"mingwX64",
468+
"androidNativeArm32",
469+
"androidNativeArm64",
470+
"androidNativeX64",
471+
"androidNativeX86",
472+
)
450473
runner {
451-
arguments.add(
452-
"-P$BANNED_TARGETS_PROPERTY_NAME=linuxArm64,linuxX64,mingwX64," +
453-
"androidNativeArm32,androidNativeArm64,androidNativeX64,androidNativeX86"
454-
)
474+
// arguments.add(
475+
// "-P$BANNED_TARGETS_PROPERTY_NAME=linuxArm64,linuxX64,mingwX64," +
476+
// "androidNativeArm32,androidNativeArm64,androidNativeX64,androidNativeX86"
477+
// )
455478
arguments.add(":klibApiDump")
456479
}
457480
}
@@ -470,11 +493,20 @@ internal class KlibVerificationTests : BaseKotlinGradleTest() {
470493
// note that the regular dump is used, where linuxArm64 is presented
471494
resolve("/examples/classes/TopLevelDeclarations.klib.dump")
472495
}
496+
disableKLibTargets(
497+
"linuxArm64",
498+
"linuxX64",
499+
"mingwX64",
500+
"androidNativeArm32",
501+
"androidNativeArm64",
502+
"androidNativeX64",
503+
"androidNativeX86",
504+
)
473505
runner {
474-
arguments.add(
475-
"-P$BANNED_TARGETS_PROPERTY_NAME=linuxArm64,linuxX64,mingwX64," +
476-
"androidNativeArm32,androidNativeArm64,androidNativeX64,androidNativeX86"
477-
)
506+
// arguments.add(
507+
// "-P$BANNED_TARGETS_PROPERTY_NAME=linuxArm64,linuxX64,mingwX64," +
508+
// "androidNativeArm32,androidNativeArm64,androidNativeX64,androidNativeX86"
509+
// )
478510
arguments.add(":klibApiCheck")
479511
}
480512
}
@@ -802,7 +834,22 @@ internal class KlibVerificationTests : BaseKotlinGradleTest() {
802834
}
803835

804836
companion object {
805-
private const val BANNED_TARGETS_PROPERTY_NAME =
806-
"binary.compatibility.validator.klib.targets.disabled.for.testing"
837+
// private const val BANNED_TARGETS_PROPERTY_NAME =
838+
// "binary.compatibility.validator.klib.targets.disabled.for.testing"
839+
840+
private fun BaseKotlinScope.disableKLibTargets(vararg targetNames: String) {
841+
buildGradleKts {
842+
val disabledTargets =
843+
targetNames.joinToString(separator = ", ", prefix = "setOf(", postfix = ")")
844+
addText(
845+
"""
846+
|binaryCompatibilityValidator.targets.withType<BCVKLibTarget>()
847+
| .matching { it.targetName in $disabledTargets }
848+
| .configureEach { this.supportedByCurrentHost.set(false) }
849+
|
850+
""".trimMargin()
851+
)
852+
}
853+
}
807854
}
808855
}

0 commit comments

Comments
 (0)