[Java] Remove unnecessary allocation.

Author: mjpt777

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/csharp/CSharpGenerator.java

@@ -437,7 +437,7 @@ private CharSequence generateCompositePropertyElements(final List<Token> tokens,
             final Token token = tokens.get(i);
             final String propertyName = formatPropertyName(token.name());
 
-            // FIXME: do I need to pass classname down here for diambiguation
+            // FIXME: do I need to pass classname down here for disambiguation
             switch (token.signal())
             {
                 case ENCODING:
@@ -616,12 +616,10 @@ private CharSequence generatePrimitiveFieldMetaData(
         final Token token,
         final String indent)
     {
-        final StringBuilder sb = new StringBuilder();
-
         final PrimitiveType primitiveType = token.encoding().primitiveType();
         final String typeName = cSharpTypeName(primitiveType);
 
-        sb.append(String.format(
+        return String.format(
             "\n" +
             indent + "public const %1$s %2$sNullValue = %3$s;\n" +
             indent + "public const %1$s %2$sMinValue = %4$s;\n" +
@@ -630,9 +628,7 @@ private CharSequence generatePrimitiveFieldMetaData(
             toUpperFirstChar(propertyName),
             generateLiteral(primitiveType, token.encoding().applicableNullValue().toString()),
             generateLiteral(primitiveType, token.encoding().applicableMinValue().toString()),
-            generateLiteral(primitiveType, token.encoding().applicableMaxValue().toString())));
-
-        return sb;
+            generateLiteral(primitiveType, token.encoding().applicableMaxValue().toString()));
     }
 
     private CharSequence generateSingleValueProperty(
@@ -646,9 +642,7 @@ private CharSequence generateSingleValueProperty(
         final ByteOrder byteOrder = token.encoding().byteOrder();
         final String byteOrderStr = generateByteOrder(byteOrder, token.encoding().primitiveType().size());
 
-        final StringBuilder sb = new StringBuilder();
-
-        sb.append(String.format("\n" +
+        return String.format("\n" +
             indent + "public %1$s %2$s\n" +
             indent + "{\n" +
             indent + INDENT + "get\n" +
@@ -666,9 +660,7 @@ private CharSequence generateSingleValueProperty(
             generateFieldNotPresentCondition(token.version(), token.encoding(), indent),
             typePrefix,
             offset,
-            byteOrderStr));
-
-        return sb;
+            byteOrderStr);
     }
 
     private CharSequence generateFieldNotPresentCondition(
@@ -1105,9 +1097,7 @@ private CharSequence generateEnumProperty(final String propertyName, final Token
         final ByteOrder byteOrder = token.encoding().byteOrder();
         final String byteOrderStr = generateByteOrder(byteOrder, token.encoding().primitiveType().size());
 
-        final StringBuilder sb = new StringBuilder();
-
-        sb.append(String.format("\n" +
+        return  String.format("\n" +
             indent + INDENT + "public %1$s %2$s\n" +
             indent + INDENT + "{\n" +
             indent + INDENT + INDENT + "get\n" +
@@ -1127,23 +1117,19 @@ private CharSequence generateEnumProperty(final String propertyName, final Token
             typePrefix,
             offset,
             byteOrderStr,
-            enumUnderlyingType));
-
-        return sb;
+            enumUnderlyingType);
     }
 
-    private Object generateBitSetProperty(final String propertyName, final Token token, final String indent)
+    private String generateBitSetProperty(final String propertyName, final Token token, final String indent)
     {
-        final StringBuilder sb = new StringBuilder();
-
         final String bitSetName = formatClassName(token.applicableTypeName());
         final int offset = token.offset();
         final String typePrefix = toUpperFirstChar(token.encoding().primitiveType().primitiveName());
         final ByteOrder byteOrder = token.encoding().byteOrder();
         final String byteOrderStr = generateByteOrder(byteOrder, token.encoding().primitiveType().size());
         final String typeName = cSharpTypeName(token.encoding().primitiveType());
 
-        sb.append(String.format("\n" +
+        return String.format("\n" +
             indent + INDENT + "public %1$s %2$s\n" +
             indent + INDENT + "{\n" +
             indent + INDENT + INDENT + "get\n" +
@@ -1163,9 +1149,7 @@ private Object generateBitSetProperty(final String propertyName, final Token tok
             typePrefix,
             offset,
             byteOrderStr,
-            typeName));
-
-        return sb;
+            typeName);
     }
 
     private Object generateCompositeProperty(final String propertyName, final Token token, final String indent)