Merge pull request #114 from amplitude/revert-112-set-session-id

Revert "Set session"

Author: djih

CHANGELOG.md

@@ -1,7 +1,5 @@
 ## Unreleased
 
-* Add setSessionId method.
-
 ### 3.4.1 (June 29, 2017)
 * Handle SDK loading errors in the load snippet. Please update the load snippets on your website to [the latest version](https://amplitude.zendesk.com/hc/en-us/articles/115001361248-JavaScript-SDK-Installation#installation).
 * Migrating setup instructions and SDK documentation in the README file to Zendesk articles.

amplitude.js

@@ -1065,19 +1065,6 @@ AmplitudeClient.prototype.setDomain = function setDomain(domain) {
   }
 };
 
-AmplitudeClient.prototype.setSessionId = function setSessionId(sessionId) {
-  if (!utils.validateInput(sessionId, 'sessionId', 'number')) {
-    return;
-  }
-
-  try {
-    this._sessionId = sessionId;
-    _saveCookieData(this);
-  } catch (e) {
-    utils.log(e);
-  }
-};
-
 /**
  * Sets an identifier for the current user.
  * @public

amplitude.min.js

@@ -584,19 +584,6 @@ AmplitudeClient.prototype.setDomain = function setDomain(domain) {
   }
 };
 
-AmplitudeClient.prototype.setSessionId = function setSessionId(sessionId) {
-  if (!utils.validateInput(sessionId, 'sessionId', 'number')) {
-    return;
-  }
-
-  try {
-    this._sessionId = sessionId;
-    _saveCookieData(this);
-  } catch (e) {
-    utils.log(e);
-  }
-};
-
 /**
  * Sets an identifier for the current user.
  * @public

src/amplitude-client.js

@@ -2692,7 +2692,6 @@ describe('setVersionName', function() {
   describe('sessionId', function() {
     var clock;
     beforeEach(function() {
-      reset();
       clock = sinon.useFakeTimers();
       amplitude.init(apiKey);
     });
@@ -2723,24 +2722,5 @@ describe('setVersionName', function() {
       assert.equal(amplitude2.getSessionId(), timestamp);
       assert.equal(amplitude2.getSessionId(), amplitude2._sessionId);
     });
-
-    it('should let user override sessionId with setSessionId', function() {
-      var amplitude2 = new AmplitudeClient();
-      var cookieStorage = new CookieStorage().getStorage();
-
-      // set up initial session
-      var sessionId = 1000;
-      clock.tick(sessionId);
-      amplitude2.init(apiKey);
-      assert.equal(amplitude2._sessionId, sessionId);
-      assert.equal(cookieStorage.get(amplitude2.options.cookieName).sessionId, sessionId);
-
-      // override sessionId with setSessionId
-      var newSessionId = 10000;
-      amplitude2.setSessionId(newSessionId);
-      assert.equal(amplitude2._sessionId, newSessionId);
-      // verify saved to cookie
-      assert.equal(cookieStorage.get(amplitude2.options.cookieName).sessionId, newSessionId);
-    });
   });
 });