Skip to content

Commit 86e4285

Browse files
committed
Ignore invalid log levels
1 parent 6f8833d commit 86e4285

File tree

4 files changed

+20
-5
lines changed

4 files changed

+20
-5
lines changed

amplitude.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2042,7 +2042,7 @@ var type = function (val) {
20422042
return typeof val === 'undefined' ? 'undefined' : _typeof(val);
20432043
};
20442044

2045-
var logLevel = 'INFO';
2045+
var logLevel = 'WARN';
20462046

20472047
var logLevels = {
20482048
DISABLE: 0,
@@ -2052,7 +2052,11 @@ var logLevels = {
20522052
};
20532053

20542054
var setLogLevel = function setLogLevel(logLevelName) {
2055-
logLevel = logLevels[logLevelName];
2055+
logLevel = logLevels[logLevelName] || logLevel;
2056+
};
2057+
2058+
var getLogLevel = function getLogLevel() {
2059+
return logLevel;
20562060
};
20572061

20582062
var log = {
@@ -2269,6 +2273,7 @@ var getQueryParam = function getQueryParam(name, query) {
22692273

22702274
var utils = {
22712275
setLogLevel: setLogLevel,
2276+
getLogLevel: getLogLevel,
22722277
log: log,
22732278
isEmptyString: isEmptyString,
22742279
getQueryParam: getQueryParam,

amplitude.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/utils.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import constants from './constants';
22
import type from './type';
33

4-
let logLevel = 'INFO';
4+
let logLevel = 'WARN';
55

66
var logLevels = {
77
DISABLE: 0,
@@ -11,7 +11,11 @@ var logLevels = {
1111
};
1212

1313
const setLogLevel = function setLogLevel(logLevelName) {
14-
logLevel = logLevels[logLevelName];
14+
logLevel = logLevels[logLevelName] || logLevel;
15+
};
16+
17+
const getLogLevel = function getLogLevel() {
18+
return logLevel;
1519
};
1620

1721
const log = {
@@ -231,6 +235,7 @@ var getQueryParam = function getQueryParam(name, query) {
231235

232236
export default {
233237
setLogLevel,
238+
getLogLevel,
234239
log,
235240
isEmptyString,
236241
getQueryParam,

test/utils.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ describe('utils', function() {
2424
console.log.restore();
2525
});
2626

27+
describe('setLogLevelShould ignore invalid log levels', function() {
28+
utils.setLogLevel('INVALID_LOGLEVEL');
29+
assert.strictEqual(utils.getLogLevel(), 'WARN');
30+
});
31+
2732
describe('logLevel is ERROR', function() {
2833
beforeEach(function() {
2934
utils.setLogLevel('ERROR');

0 commit comments

Comments
 (0)