removed utm and referrer from identify events

Author: djih

amplitude.js

@@ -260,7 +260,7 @@ Amplitude.prototype.init = function(apiKey, opt_userId, opt_config, callback) {
     log(e);
   }
 
-  if (callback && typeof(callback) === 'function') {
+  if (callback && type(callback) === 'function') {
     callback();
   }
 };
@@ -508,7 +508,7 @@ var _truncateValue = function(value) {
  * Private logEvent method. Keeps apiProperties from being publicly exposed.
  */
 Amplitude.prototype._logEvent = function(eventType, eventProperties, apiProperties, userProperties, callback) {
-  if (typeof callback !== 'function') {
+  if (type(callback) !== 'function') {
     callback = null;
   }
 
@@ -536,16 +536,18 @@ Amplitude.prototype._logEvent = function(eventType, eventProperties, apiProperti
     this._lastEventTime = eventTime;
     localStorage.setItem(LocalStorageKeys.LAST_EVENT_TIME, this._lastEventTime);
 
-    // Add the utm properties, if any, onto the user properties.
     userProperties = userProperties || {};
-    object.merge(userProperties, this._utmProperties);
-
-    // Add referral info onto the user properties
-    if (this.options.includeReferrer) {
-      object.merge(userProperties, {
-        'referrer': this._getReferrer(),
-        'referring_domain': this._getReferringDomain()
-      });
+    // Only add utm properties to user properties for events
+    if (eventType !== IDENTIFY_EVENT) {
+      object.merge(userProperties, this._utmProperties);
+
+      // Add referral info onto the user properties
+      if (this.options.includeReferrer) {
+        object.merge(userProperties, {
+          'referrer': this._getReferrer(),
+          'referring_domain': this._getReferringDomain()
+        });
+      }
     }
 
     apiProperties = apiProperties || {};

amplitude.min.js

@@ -148,7 +148,7 @@ Amplitude.prototype.init = function(apiKey, opt_userId, opt_config, callback) {
     log(e);
   }
 
-  if (callback && typeof(callback) === 'function') {
+  if (callback && type(callback) === 'function') {
     callback();
   }
 };
@@ -396,7 +396,7 @@ var _truncateValue = function(value) {
  * Private logEvent method. Keeps apiProperties from being publicly exposed.
  */
 Amplitude.prototype._logEvent = function(eventType, eventProperties, apiProperties, userProperties, callback) {
-  if (typeof callback !== 'function') {
+  if (type(callback) !== 'function') {
     callback = null;
   }
 
@@ -424,16 +424,18 @@ Amplitude.prototype._logEvent = function(eventType, eventProperties, apiProperti
     this._lastEventTime = eventTime;
     localStorage.setItem(LocalStorageKeys.LAST_EVENT_TIME, this._lastEventTime);
 
-    // Add the utm properties, if any, onto the user properties.
     userProperties = userProperties || {};
-    object.merge(userProperties, this._utmProperties);
-
-    // Add referral info onto the user properties
-    if (this.options.includeReferrer) {
-      object.merge(userProperties, {
-        'referrer': this._getReferrer(),
-        'referring_domain': this._getReferringDomain()
-      });
+    // Only add utm properties to user properties for events
+    if (eventType !== IDENTIFY_EVENT) {
+      object.merge(userProperties, this._utmProperties);
+
+      // Add referral info onto the user properties
+      if (this.options.includeReferrer) {
+        object.merge(userProperties, {
+          'referrer': this._getReferrer(),
+          'referring_domain': this._getReferringDomain()
+        });
+      }
     }
 
     apiProperties = apiProperties || {};

src/amplitude.js

@@ -1126,15 +1126,11 @@ describe('Amplitude', function() {
       amplitude.setUserProperties({user_prop: true});
       assert.lengthOf(server.requests, 1);
       var events = JSON.parse(querystring.parse(server.requests[0].requestBody).e);
+      // identify event should not have utm properties
       assert.deepEqual(events[0].user_properties, {
         '$set': {
           'user_prop': true
-        },
-        utm_campaign: 'new',
-        utm_content: 'top',
-        utm_medium: 'email',
-        utm_source: 'amplitude',
-        utm_term: 'terms'
+        }
       });
       server.respondWith('success');
       server.respond();
@@ -1226,17 +1222,25 @@ describe('Amplitude', function() {
       });
     });
 
-    it('should add referrer data to the user properties', function() {
+    it('should add referrer data to the user properties on events only', function() {
       reset();
       amplitude.init(apiKey, undefined, {includeReferrer: true});
 
       amplitude.setUserProperties({user_prop: true});
-       assert.lengthOf(server.requests, 1);
+      assert.lengthOf(server.requests, 1);
       var events = JSON.parse(querystring.parse(server.requests[0].requestBody).e);
       assert.deepEqual(events[0].user_properties, {
         $set: {
           'user_prop': true
-        },
+        }
+      });
+      server.respondWith('success');
+      server.respond();
+
+      amplitude.logEvent('Referrer test event');
+      assert.lengthOf(server.requests, 2);
+      var events = JSON.parse(querystring.parse(server.requests[1].requestBody).e);
+      assert.deepEqual(events[0].user_properties, {
         referrer: 'https://amplitude.com/contact',
         referring_domain: 'amplitude.com'
       });