Skip to content

Commit c8aaa6b

Browse files
committed
update changelog and cleanup test
1 parent 96ce02f commit c8aaa6b

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
## Unreleased
22

3-
* Add setting to batch events to send to in a single request.
3+
* Add option to batch events into a single request.
44

55
## 2.2.1 (Aug 13, 2015)
66

test/amplitude.js

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -288,17 +288,15 @@ describe('Amplitude', function() {
288288
});
289289

290290
it('should batch events sent', function() {
291-
var threshold = 10;
292-
var additional = threshold/2;
293-
amplitude.init(apiKey, null, {batchEvents: true, eventUploadThreshold: threshold});
291+
amplitude.init(apiKey, null, {batchEvents: true, eventUploadThreshold: 10});
294292

295-
for (var i = 0; i < (threshold + additional); i++) {
293+
for (var i = 0; i < 15; i++) {
296294
amplitude.logEvent('Event', {index: i});
297295
}
298296

299297
assert.lengthOf(server.requests, 1);
300298
var events = JSON.parse(querystring.parse(server.requests[0].requestBody).e);
301-
assert.lengthOf(events, threshold);
299+
assert.lengthOf(events, 10);
302300
assert.deepEqual(events[0].event_properties, {index: 0});
303301
assert.deepEqual(events[9].event_properties, {index: 9});
304302

@@ -307,8 +305,8 @@ describe('Amplitude', function() {
307305

308306
assert.lengthOf(server.requests, 1);
309307
var unsentEvents = amplitude._unsentEvents;
310-
assert.lengthOf(unsentEvents, additional);
311-
assert.deepEqual(unsentEvents[additional - 1].event_properties, {index: threshold + additional - 1});
308+
assert.lengthOf(unsentEvents, 5);
309+
assert.deepEqual(unsentEvents[4].event_properties, {index: 14});
312310
});
313311

314312
it('should back off on 413 status', function() {

0 commit comments

Comments
 (0)