add tests

Author: Daniel Jih

amplitude.js

@@ -568,9 +568,6 @@ AmplitudeClient.prototype.init = function init(apiKey, opt_userId, opt_config, o
     this.options.userId = (type(opt_userId) === 'string' && !utils.isEmptyString(opt_userId) && opt_userId) ||
         this.options.userId || null;
 
-    // if custom session id specified in config, override what is stored in cookie
-    this._sessionId = this.options.sessionId > 0 ? this.options.sessionId : this._sessionId;
-
     // load unsent events and identifies before any attempt to log new ones
     if (this.options.saveEvents) {
       this._unsentEvents = this._loadSavedUnsentEvents(this.options.unsentKey);
@@ -5021,7 +5018,6 @@ module.exports = {
   includeGclid: false,
   saveParamsReferrerOncePerSession: true,
   deviceIdFromUrlParam: false,
-  sessionId: 0,
 };
 
 }, {"./language":29}],

amplitude.min.js

@@ -87,9 +87,6 @@ AmplitudeClient.prototype.init = function init(apiKey, opt_userId, opt_config, o
     this.options.userId = (type(opt_userId) === 'string' && !utils.isEmptyString(opt_userId) && opt_userId) ||
         this.options.userId || null;
 
-    // if custom session id specified in config, override what is stored in cookie
-    this._sessionId = this.options.sessionId > 0 ? this.options.sessionId : this._sessionId;
-
     // load unsent events and identifies before any attempt to log new ones
     if (this.options.saveEvents) {
       this._unsentEvents = this._loadSavedUnsentEvents(this.options.unsentKey);

src/amplitude-client.js

@@ -24,5 +24,4 @@ module.exports = {
   includeGclid: false,
   saveParamsReferrerOncePerSession: true,
   deviceIdFromUrlParam: false,
-  sessionId: 0,
 };

src/options.js

@@ -2692,6 +2692,7 @@ describe('setVersionName', function() {
   describe('sessionId', function() {
     var clock;
     beforeEach(function() {
+      reset();
       clock = sinon.useFakeTimers();
       amplitude.init(apiKey);
     });
@@ -2722,5 +2723,24 @@ describe('setVersionName', function() {
       assert.equal(amplitude2.getSessionId(), timestamp);
       assert.equal(amplitude2.getSessionId(), amplitude2._sessionId);
     });
+
+    it('should let user override sessionId with setSessionId', function() {
+      var amplitude2 = new AmplitudeClient();
+      var cookieStorage = new CookieStorage().getStorage();
+
+      // set up initial session
+      var sessionId = 1000;
+      clock.tick(sessionId);
+      amplitude2.init(apiKey);
+      assert.equal(amplitude2._sessionId, sessionId);
+      assert.equal(cookieStorage.get(amplitude2.options.cookieName).sessionId, sessionId);
+
+      // override sessionId with setSessionId
+      var newSessionId = 10000;
+      amplitude2.setSessionId(newSessionId);
+      assert.equal(amplitude2._sessionId, newSessionId);
+      // verify saved to cookie
+      assert.equal(cookieStorage.get(amplitude2.options.cookieName).sessionId, newSessionId);
+    });
   });
 });