fast output type checking

Author: andkom

src/AddressSerializer.php

@@ -4,7 +4,6 @@
 
 namespace AndKom\Bitcoin\Blockchain;
 
-use AndKom\Bitcoin\Blockchain\Exception\AddressException;
 use AndKom\Bitcoin\Blockchain\Network\Bitcoin;
 use function BitWasp\Bech32\encodeSegwit;
 use StephenHill\Base58;

src/Script.php

@@ -17,6 +17,11 @@ class Script
      */
     public $data;
 
+    /**
+     * @var
+     */
+    public $size;
+
     /**
      * @var array
      */
@@ -54,6 +59,7 @@ public function getData(): string
     public function setData(string $data): self
     {
         $this->data = $data;
+        $this->size = strlen($data);
         $this->operations = null;
         return $this;
     }

src/ScriptPubKey.php

@@ -18,89 +18,104 @@ class ScriptPubKey extends Script
      */
     public function isReturn(): bool
     {
-        $operations = $this->parse();
-
-        return count($operations) >= 1 &&
-            $operations[0]->code == Opcodes::OP_RETURN;
+        return $this->size >= 1 && ord($this->data[0]) == Opcodes::OP_RETURN;
     }
 
     /**
      * @return bool
      */
     public function isPayToPubKey(): bool
     {
-        $operations = $this->parse();
+        // compressed pubkey
+        if ($this->size == 35 &&
+            ord($this->data[0]) == 33 &&
+            ord($this->data[-1]) == Opcodes::OP_CHECKSIG &&
+            ($this->data[1] == "\x02" || $this->data[1] == "\x03")) {
+            return true;
+        }
+
+        // uncompressed pubkey
+        if ($this->size == 67 &&
+            ord($this->data[0]) == 65 &&
+            ord($this->data[-1]) == Opcodes::OP_CHECKSIG &&
+            $this->data[1] == "\x04") {
+            return true;
+        }
 
-        return count($operations) == 2 &&
-            ($operations[0]->size == 33 || $operations[0]->size == 65) &&
-            $operations[1]->code == Opcodes::OP_CHECKSIG;
+        return false;
     }
 
     /**
      * @return bool
      */
     public function isPayToPubKeyHash(): bool
     {
-        $operations = $this->parse();
-
-        return count($operations) == 5 &&
-            $operations[0]->code == Opcodes::OP_DUP &&
-            $operations[1]->code == Opcodes::OP_HASH160 &&
-            $operations[2]->size == 20 &&
-            $operations[3]->code == Opcodes::OP_EQUALVERIFY &&
-            $operations[4]->code == Opcodes::OP_CHECKSIG;
+        return $this->size == 25 &&
+            ord($this->data[0]) == Opcodes::OP_DUP &&
+            ord($this->data[1]) == Opcodes::OP_HASH160 &&
+            ord($this->data[2]) == 20 &&
+            ord($this->data[-2]) == Opcodes::OP_EQUALVERIFY &&
+            ord($this->data[-1]) == Opcodes::OP_CHECKSIG;
     }
 
     /**
      * @return bool
      */
     public function isPayToScriptHash(): bool
     {
-        $operations = $this->parse();
-
-        return count($operations) == 3 &&
-            $operations[0]->code == Opcodes::OP_HASH160 &&
-            $operations[1]->size == 20 &&
-            $operations[2]->code == Opcodes::OP_EQUAL;
+        return $this->size == 23 &&
+            ord($this->data[0]) == Opcodes::OP_HASH160 &&
+            ord($this->data[1]) == 20 &&
+            ord($this->data[-1]) == Opcodes::OP_EQUAL;
     }
 
     /**
      * @return bool
      */
     public function isMultisig(): bool
     {
-        $operations = $this->parse();
+        $keys = ord($this->data[0]);
+        $sigs = ord($this->data[-2]);
+
+        if (!($this->size >= 24 &&
+            $keys >= Opcodes::OP_1 && $keys <= Opcodes::OP_16 &&
+            $sigs && $sigs <= Opcodes::OP_16 &&
+            $keys >= $sigs &&
+            ord($this->data[-1]) == Opcodes::OP_CHECKMULTISIG)) {
+            return false;
+        }
+
+        for ($i = 1, $k = 0; $i < $this->size - 2; $i += 21, $k++) {
+            if (ord($this->data[$i]) != 20) {
+                return false;
+            }
+        }
 
-        return ($count = count($operations)) >= 4 &&
-            $operations[0]->code >= Opcodes::OP_1 &&
-            $operations[$count - 2]->code >= Opcodes::OP_1 &&
-            $operations[$count - 1]->code == Opcodes::OP_CHECKMULTISIG;
+        return $keys - Opcodes::OP_1 + 1 == $k;
     }
 
     /**
      * @return bool
      */
     public function isPayToWitnessPubKeyHash(): bool
     {
-        $operations = $this->parse();
+        $version = ord($this->data[0]);
 
-        return count($operations) == 2 &&
-            $operations[0]->code >= Opcodes::OP_0 &&
-            $operations[0]->code <= Opcodes::OP_16 &&
-            $operations[1]->size == 20;
+        return $this->size == 22 &&
+            $version >= Opcodes::OP_0 && $version <= Opcodes::OP_16 &&
+            ord($this->data[1]) == 20;
     }
 
     /**
      * @return bool
      */
     public function isPayToWitnessScriptHash(): bool
     {
-        $operations = $this->parse();
+        $version = ord($this->data[0]);
 
-        return count($operations) == 2 &&
-            $operations[0]->code >= Opcodes::OP_0 &&
-            $operations[0]->code <= Opcodes::OP_16 &&
-            $operations[1]->size == 32;
+        return $this->size == 34 &&
+            $version >= Opcodes::OP_0 && $version <= Opcodes::OP_16 &&
+            ord($this->data[1]) == 32;
     }
 
     /**

tests/ScriptPubKeyTest.php

@@ -78,14 +78,14 @@ public function testParseP2SH()
     // [numsigs] [...pubkeys...] [numpubkeys] OP_CHECKMULTISIG
     public function testParseMultisig()
     {
-        $hex = '52'; // OP_2
+        $hex = '53'; // OP_3
         $hex .= '14'; // OP_PUSHDATA
         $hex .= '91b24bf9f5288532960ac687abb035127b1d28a5'; // pubkey hash
         $hex .= '14'; // OP_PUSHDATA
         $hex .= 'd6c8e828c1eca1bba065e1b83e1dc2a36e387a42'; // pubkey hash
         $hex .= '14'; // OP_PUSHDATA
         $hex .= 'ec7eced2c57ed1292bc4eb9bfd13c9f7603bc338'; // pubkey hash
-        $hex .= '53'; // OP_3
+        $hex .= '52'; // OP_2
         $hex .= 'ae'; // OP_CHECKMULTISIG
 
         $script = new ScriptPubKey(hex2bin($hex));