Skip to content

Commit 6d17438

Browse files
committed
Remove focal build, add registry and tag vars to .env
1 parent 4db145c commit 6d17438

File tree

6 files changed

+19
-26
lines changed

6 files changed

+19
-26
lines changed

.env

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
# Your numeric uid and gid
22
HOSTUID=
33
HOSTGID=
4+
TAG=v3-jammy
5+
REGISTRY_IMAGE=andy5995/linuxdeploy
46

57
# When run from the root of your project directory, this will be
68
# the location in the container

.github/workflows/docker.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ jobs:
2929
- ubuntu-24.04-arm
3030
- ubuntu-24.04
3131
codename:
32-
- focal
3332
- jammy
3433

3534
fail-fast: true
@@ -97,7 +96,6 @@ jobs:
9796
strategy:
9897
matrix:
9998
codename:
100-
- focal
10199
- jammy
102100
fail-fast: true
103101

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
test-rmw:
2828
runs-on: ubuntu-latest
2929
env:
30-
REGISTRY_IMAGE: andy5995/linuxdeploy:v3-focal
30+
REGISTRY_IMAGE: andy5995/linuxdeploy:v3-jammy
3131
DOCKER_CACHE_DEST: ${{ github.workspace }}/.docker/buildx-cache-${{ matrix.platform }}
3232
strategy:
3333
matrix:
@@ -103,7 +103,7 @@ jobs:
103103
. \
104104
-t $REGISTRY_IMAGE \
105105
--platform=${{ matrix.platform }} \
106-
--build-arg CODENAME=focal \
106+
--build-arg CODENAME=jammy \
107107
--cache-to=type=local,dest=${{ env.DOCKER_CACHE_DEST }} \
108108
--cache-from=type=local,src=${{ env.DOCKER_CACHE_DEST }} \
109109
--load

Dockerfile

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
ARG CODENAME=focal
1+
ARG CODENAME=jammy
22
FROM ubuntu:$CODENAME
3-
ARG CODENAME=focal
3+
ARG CODENAME=jammy
44

55
ARG DEBIAN_FRONTEND=noninteractive
66
RUN \
@@ -118,19 +118,11 @@ USER root
118118
ARG DEBIAN_FRONTEND=noninteractive
119119
RUN \
120120
apt update && \
121-
if [ "$CODENAME" = "focal" ];then \
122-
apt install --no-install-recommends -y \
123-
libgtk2.0-dev \
124-
libgtk-3-dev \
125-
nlohmann-json3-dev \
126-
qt5-default; \
127-
else \
128-
apt install --no-install-recommends -y \
129-
libgtk2.0-dev \
130-
libgtk-3-dev \
131-
nlohmann-json3-dev \
132-
qtbase5-dev; \
133-
fi && \
121+
apt install --no-install-recommends -y \
122+
libgtk2.0-dev \
123+
libgtk-3-dev \
124+
nlohmann-json3-dev \
125+
qtbase5-dev && \
134126
rm -rf /var/lib/apt/lists
135127

136128
USER builder

README.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,7 @@ A docker container that aims to help build an
44
[AppImage](https://github.com/AppImage/AppImageKit) on multiple architectures
55
using [linuxdeploy](https://github.com/linuxdeploy/linuxdeploy).
66

7-
Latest version: v3-focal
8-
9-
v3-jammy is also available if for some reason you require a more recent
10-
version Ubuntu.
7+
Latest version: v3-jammy
118

129
## Available architectures
1310

@@ -45,7 +42,11 @@ You may use `sudo` in your script to install packages or do other things.
4542

4643
If you would like to look around the container, you can use
4744

48-
docker run -it --rm --entrypoint bash andy5995/linuxdeploy:v3-focal
45+
docker run -it --rm --entrypoint bash andy5995/linuxdeploy:v3-jammy
46+
47+
> [!NOTE]
48+
> The image is also available from the GitHub Container Registry:
49+
> `docker pull ghcr.io/andy5995/linuxdeploy-build-helper-container:v3-jammy`
4950
5051
## Locally
5152

@@ -83,7 +84,7 @@ These plugins are installed in the container:
8384

8485
## Note
8586

86-
The container runs Ubuntu 20.04 (Focal Fossil). See [this
87+
The container runs Ubuntu 22.04 (Jammy Jellyfish). See [this
8788
discussion](https://github.com/orgs/AppImage/discussions/1254) for more
8889
details on why I chose that version of Ubuntu.
8990

docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ services:
44
HOSTUID: ${HOSTUID}
55
HOSTGID: ${HOSTGID}
66
VERSION: ${VERSION}
7-
image: andy5995/linuxdeploy:v3-focal
7+
image: ${REGISTRY_IMAGE}:${TAG}
88
platform: ${PLATFORM:-linux/amd64}
99
volumes:
1010
- $PWD:$WORKSPACE

0 commit comments

Comments
 (0)