Skip to content

Commit a0920af

Browse files
committed
fix(e2e): properly use some promises in e2e tests
1 parent 3c1bff7 commit a0920af

File tree

6 files changed

+10
-6
lines changed

6 files changed

+10
-6
lines changed

app/templates/e2e/account(auth)/login/login.po.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ var LoginPage = function() {
2020
}
2121
}
2222

23-
form.submit.click();
23+
return form.submit.click();
2424
};
2525
};
2626

app/templates/e2e/account(auth)/login/login.spec(mocha).js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,9 @@ describe('Login View', function() {
88
var page;
99

1010
var loadPage = function() {
11-
browser.get(config.baseUrl + '/login');
11+
let promise = browser.get(config.baseUrl + '/login');
1212
page = require('./login.po');
13+
return promise;
1314
};
1415

1516
var testUser = {

app/templates/e2e/account(auth)/logout/logout.spec(mocha).js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@ var UserModel = require(config.serverConfig.root + '/server/sqldb').User;<% } %>
66

77
describe('Logout View', function() {
88
var login = function(user) {
9-
browser.get(config.baseUrl + '/login');
9+
let promise = browser.get(config.baseUrl + '/login');
1010
require('../login/login.po').login(user);
11+
return promise;
1112
};
1213

1314
var testUser = {

app/templates/e2e/account(auth)/signup/signup.po.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ var SignupPage = function() {
2222
}
2323
}
2424

25-
form.submit.click();
25+
return form.submit.click();
2626
};
2727
};
2828

app/templates/e2e/account(auth)/signup/signup.spec(mocha).js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@ describe('Signup View', function() {
99

1010
var loadPage = function() {
1111
browser.manage().deleteAllCookies()
12-
browser.get(config.baseUrl + '/signup');
12+
let promise = browser.get(config.baseUrl + '/signup');
1313
page = require('./signup.po');
14+
return promise;
1415
};
1516

1617
var testUser = {

app/templates/e2e/main/main.spec(mocha).js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@ describe('Main View', function() {
66
var page;
77

88
beforeEach(function() {
9-
browser.get(config.baseUrl + '/');
9+
let promise = browser.get(config.baseUrl + '/');
1010
page = require('./main.po');
11+
return promise;
1112
});
1213

1314
it('should include jumbotron with correct data', function() {

0 commit comments

Comments
 (0)