Skip to content

Commit 9141967

Browse files
chore(package): update to core 5.0.12
test(urlRouter): fix test for core 5.0.12
1 parent a3fb2ee commit 9141967

File tree

3 files changed

+20
-7
lines changed

3 files changed

+20
-7
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
"jsnext:main": "lib-esm/index.js",
7373
"typings": "lib/index.d.ts",
7474
"dependencies": {
75-
"@uirouter/core": "5.0.11"
75+
"@uirouter/core": "5.0.12"
7676
},
7777
"peerDependencies": {
7878
"angular": ">=1.2.0"

test/urlRouterSpec.ts

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -227,15 +227,28 @@ describe("UrlRouter", function () {
227227
it('can read and sync a copy of location URL', inject(function($urlRouter, $location) {
228228
$location.url('/old');
229229

230-
spyOn(router.locationService, 'path').and.callThrough();
230+
spyOn(router.locationService, 'url').and.callThrough();
231231
$urlRouter.update(true);
232-
expect(router.locationService.path).toHaveBeenCalled();
232+
expect(router.locationService.url).toHaveBeenCalled();
233233

234234
$location.url('/new');
235235
$urlRouter.update();
236236

237237
expect($location.url()).toBe('/old');
238238
}));
239+
240+
it('can read and sync a copy of location URL including query params', inject(function($urlRouter, $location) {
241+
$location.url('/old?param=foo');
242+
243+
spyOn(router.locationService, 'url').and.callThrough();
244+
$urlRouter.update(true);
245+
expect(router.locationService.url).toHaveBeenCalled();
246+
247+
$location.url('/new?param=bar');
248+
$urlRouter.update();
249+
250+
expect($location.url()).toBe('/old?param=foo');
251+
}));
239252
});
240253

241254
describe("URL generation", function() {
@@ -277,4 +290,4 @@ describe("UrlRouter", function () {
277290
});
278291
});
279292

280-
});
293+
});

yarn.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,9 @@
7474
"@types/glob" "*"
7575
"@types/node" "*"
7676

77-
"@uirouter/core@5.0.11":
78-
version "5.0.11"
79-
resolved "https://registry.yarnpkg.com/@uirouter/core/-/core-5.0.11.tgz#bec461fcda767d79c98f6647cc9313ef9e5de03a"
77+
"@uirouter/core@5.0.12":
78+
version "5.0.12"
79+
resolved "https://registry.yarnpkg.com/@uirouter/core/-/core-5.0.12.tgz#de6a7386af9c5f01328c93e5b8c37d9cbfc31e37"
8080

8181
"@uirouter/publish-scripts@2.0.6":
8282
version "2.0.6"

0 commit comments

Comments
 (0)