Skip to content

Commit 59dc8d1

Browse files
authored
fix: Remove unused fields from FileScanTask (#2777)
Closes #2776 # Rationale for this change This PR removes the unused `start` and `length` fields from the `FileScanTask`. While working on the models for rest scanning in #2775 we noticed that these fields were initialized but never accessed or used anywhere in the code base. ## Are these changes tested? ``` > make test ... 3023 passed, 1392 deselected in 30.39s ``` ## Are there any user-facing changes? no
1 parent 36baca9 commit 59dc8d1

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

pyiceberg/table/__init__.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1786,22 +1786,16 @@ class FileScanTask(ScanTask):
17861786

17871787
file: DataFile
17881788
delete_files: set[DataFile]
1789-
start: int
1790-
length: int
17911789
residual: BooleanExpression
17921790

17931791
def __init__(
17941792
self,
17951793
data_file: DataFile,
17961794
delete_files: set[DataFile] | None = None,
1797-
start: int | None = None,
1798-
length: int | None = None,
17991795
residual: BooleanExpression = ALWAYS_TRUE,
18001796
) -> None:
18011797
self.file = data_file
18021798
self.delete_files = delete_files or set()
1803-
self.start = start or 0
1804-
self.length = length or data_file.file_size_in_bytes
18051799
self.residual = residual
18061800

18071801

0 commit comments

Comments
 (0)