Commit 911a2eb
fix: use correct config for storage classes to avoid memory leaks (#3144)
Currently RequestQueue, Dataset, KeyValueStore is always referencing the
global config (`Configuration.getGlobalConfig()`) instead of the config
that is passed to the crawler.
<img width="915" height="910" alt="Screenshot 2025-08-28 at 10 31 45"
src="https://github.com/user-attachments/assets/4ba9171d-7f74-4470-b206-82ba5d36f742"
/>
<img width="1056" height="1283" alt="Screenshot 2025-08-29 at 13 34 22"
src="https://github.com/user-attachments/assets/0b18a2a6-dde4-43a5-8fda-28144ec307c9"
/>
---------
Co-authored-by: Martin Adámek <banan23@gmail.com>1 parent 2094fdd commit 911a2eb
File tree
3 files changed
+30
-8
lines changed- packages
- basic-crawler/src/internals
- core/src/storages
- test/core/crawlers
3 files changed
+30
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
976 | 976 | | |
977 | 977 | | |
978 | 978 | | |
979 | | - | |
| 979 | + | |
| 980 | + | |
| 981 | + | |
| 982 | + | |
| 983 | + | |
980 | 984 | | |
981 | 985 | | |
982 | 986 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
91 | 93 | | |
92 | 94 | | |
93 | 95 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1796 | 1796 | | |
1797 | 1797 | | |
1798 | 1798 | | |
| 1799 | + | |
| 1800 | + | |
| 1801 | + | |
| 1802 | + | |
| 1803 | + | |
| 1804 | + | |
| 1805 | + | |
| 1806 | + | |
| 1807 | + | |
| 1808 | + | |
| 1809 | + | |
| 1810 | + | |
| 1811 | + | |
| 1812 | + | |
| 1813 | + | |
| 1814 | + | |
1799 | 1815 | | |
1800 | 1816 | | |
0 commit comments