Chunk implementation for AR

Author: Samuel Akopyan

demos/simple-blog/protected/controllers/PostsController.php

@@ -135,21 +135,27 @@ public function indexAction($msg = '')
 		if (!$this->_view->currentPage) {
 			$this->_view->actionMessage = CWidget::create('CMessage', array('error', 'Wrong parameter passed! Please try again later.', array('button' => true)));
 		} else {
-/*			$this->_view->posts = Posts::model()->findAll(array(
-				'limit' => (($this->_view->currentPage - 1) * $this->_view->pageSize) . ', ' . $this->_view->pageSize,
-				'order' => 'post_datetime DESC',
-			));*/
+            $conditions = array(
+                'limit' => (($this->_view->currentPage - 1) * $this->_view->pageSize) . ', ' . $this->_view->pageSize,
+                'order' => 'post_datetime DESC',
+            );
 
-            $posts = null;
-            Posts::model()->chunk(2, function ($records) use(&$posts){
-                foreach ($records as $key => $record) {
-                    $posts[] = $record;
-                }
-                //CDebug::d($record);
-            });
-            //CDebug::dd($posts);
-
-            $this->_view->posts = $posts;
+            if (!true) {
+                $this->_view->posts = Posts::model()->findAll(array(
+                    'limit' => (($this->_view->currentPage - 1) * $this->_view->pageSize) . ', ' . $this->_view->pageSize,
+                    'order' => 'post_datetime DESC',
+                ));
+            }else{
+                $posts = null;
+                Posts::model()->chunk($conditions, [], -2, function ($records) use(&$posts){
+                    foreach ($records as $key => $record) {
+                        $posts[] = $record;
+                    }
+                    //CDebug::d($record);
+                });
+                //CDebug::dd($posts);
+                $this->_view->posts = $posts;
+            }
 		}
 
 		$this->_view->render('posts/index');

framework/db/CActiveRecord.php

@@ -581,24 +581,46 @@ private function _createObjectFromTable()
 
     /**
      * Split AR result into parts (chunks)
+     * Ex.: chunk(array('condition'=>'post_id = :postID AND is_active = :isActive', 'select'=>'', 'group|groupBy'=>'', 'order|orderBy'=>'id DESC', 'limit'=>'0, 10'), array(':postID'=>10, ':isActive'=>1));
+     * Ex.: chunk(CConfig::get('db.prefix').$this->_tableTranslation.'.news_text LIKE :keywords', array(':keywords'=>'%'.$keywords.'%'));
+     *
+     * @param  array  $conditions
+     * @param  array  $params
      * @param  int  $size
-     * @param  null  $callback
+     * @param  callable  $callback
+     *
+     * @return null
      */
-    public function chunk(int $size, callable $callback = null)
+    public function chunk(array $conditions = [], array $params = [], int $size = 0, callable $callback = null)
     {
         if (is_int($size) && $size > 0 && !empty($callback)) {
-            $from = 0;
-//            echo('limit'."$from, $size");
-            while ($result = $this->findAll(array('limit'=>"$from, $size"))){
+            if (!isset($conditions['limit'])) {
+                $from = 0;
+                $limitSize = $size;
+            } else {
+                $limitParts = explode(',', $conditions['limit']);
+                $from = isset($limitParts[0]) ? $limitParts[0] : 0;
+                $limitSize = isset($limitParts[1]) ? $limitParts[1] : $size;
+                if ($size >= $limitSize) {
+                    $size = $limitSize;
+                }
+            }
+
+            $conditions['limit'] = "$from, $size";
+            $count = 0;
+
+            while ($result = $this->findAll($conditions, $params)){
                 $callback($result);
                 $from += $size;
-//                echo('limit'."$from, $size");
-//                if ($from > 10){
-//                    return;
-//                }
+                $conditions['limit'] = "$from, $size";
+
+                $count += $size;
+                if ($count >= $limitSize) {
+                    break;
+                }
             }
         } else {
-            CDebug::AddMessage('errors', 'chunk', A::t('core', 'Wrong params for chunk: {size} or callback method is callable.', array('{size}' => $size)));
+            CDebug::AddMessage('errors', 'chunk', A::t('core', 'Wrong params for chunk size: {size} or callback method is callable.', array('{size}' => $size)));
         }
 
         return null;
@@ -713,16 +735,19 @@ public function findByPk($pk, $conditions = '', $params = array(), $cacheId = fa
 			return null;
 		}
 	}
-	
-	/**
-	 * This method queries your database to find related objects by attributes
-	 * Ex.: findByAttributes($attributes, 'postID = :postID AND isActive = :isActive', array(':postID'=>10, ':isActive'=>1));
-	 * Ex.: findByAttributes($attributes, array('condition'=>'postID = :postID AND isActive = :isActive', 'order|orderBy'=>'id DESC', 'limit'=>'0, 10'), 'params'=>array(':postID'=>10, ':isActive'=>1));
-	 * Ex.: $attributes = array('first_name'=>$firstName, 'last_name'=>$lastName);
-	 * @param array $attributes
-	 * @param mixed $conditions
-	 * @param array $params
-	 */
+
+    /**
+     * This method queries your database to find related objects by attributes
+     * Ex.: findByAttributes($attributes, 'postID = :postID AND isActive = :isActive', array(':postID'=>10, ':isActive'=>1));
+     * Ex.: findByAttributes($attributes, array('condition'=>'postID = :postID AND isActive = :isActive', 'order|orderBy'=>'id DESC', 'limit'=>'0, 10'), 'params'=>array(':postID'=>10, ':isActive'=>1));
+     * Ex.: $attributes = array('first_name'=>$firstName, 'last_name'=>$lastName);
+     *
+     * @param  array  $attributes
+     * @param  mixed  $conditions
+     * @param  array  $params
+     *
+     * @return mixed
+     */
 	public function findByAttributes($attributes, $conditions = '', $params = array())
 	{
 		if (is_array($conditions)) {

framework/messages/ar/core.php

@@ -186,4 +186,5 @@
 	'You cannot delete the last remaining record in table {table}!' => 'لا يمكنك حذف السجل الأخير المتبقي في الجدول {table}!',
 	'Warnings' => 'تحذيرات',
 	'Wrong column name: {index} in table {table}' => 'اسم عمود غير صحيح: "{index}" في الجدول "{table}" - لا يمكن الوصول إلى خاصية غير موجودة لكائن AR',
+    'Wrong params for chunk size: {size} or callback method is callable.' => 'Wrong params for chunk size: {size} or callback method is callable.',
 );

framework/messages/de/core.php

@@ -184,4 +184,5 @@
 'You cannot delete the last remaining record in table {table}!' => 'Sie können die letzten verbliebenen Satz in der Tabelle {table} nicht löschen!',
 'Warnings' => 'Warnungen',
 'Wrong column name: {index} in table {table}' => 'Falsche Spalte name: {index} in Tabelle {table}',
+'Wrong params for chunk size: {size} or callback method is callable.' => 'Wrong params for chunk size: {size} or callback method is callable.',
 );

framework/messages/en/core.php

@@ -186,4 +186,5 @@
 	'You cannot delete the last remaining record in table {table}!' => 'You cannot delete the last remaining record in table {table}!',
 	'Warnings' => 'Warnings',
 	'Wrong column name: {index} in table {table}' => 'Wrong column name: "{index}" in table "{table}" - can\'t access non existent property of AR object',
+    'Wrong params for chunk size: {size} or callback method is callable.' => 'Wrong params for chunk size: {size} or callback method is callable.',
 );

framework/messages/es/core.php

@@ -186,4 +186,5 @@
 	'You cannot delete the last remaining record in table {table}!' => 'No se puede eliminar el único registro existente en la tabla {table}.',
 	'Warnings' => 'Advertencias',
 	'Wrong column name: {index} in table {table}' => 'Nombre de columna incorrecta: {index} en la tabla {table}.',
+    'Wrong params for chunk size: {size} or callback method is callable.' => 'Wrong params for chunk size: {size} or callback method is callable.',
 );

framework/messages/fr/core.php

@@ -186,4 +186,5 @@
 	'You cannot delete the last remaining record in table {table}!' => 'Vous ne pouvez pas supprimer le dernier enregistrement restante dans le tableau {table}!',
 	'Warnings' => 'Avertissements',
 	'Wrong column name: {index} in table {table}' => 'Nom de colonne incorrect: {index} dans la table {table}',
+    'Wrong params for chunk size: {size} or callback method is callable.' => 'Wrong params for chunk size: {size} or callback method is callable.',
 );

framework/messages/he/core.php

@@ -186,4 +186,5 @@
 	'You cannot delete the last remaining record in table {table}!' => 'לא ניתן למחוק את הרשומה האחרונה שנותרה בטבלה {table}!',
 	'Warnings' => 'אזהרות',
 	'Wrong column name: {index} in table {table}' => 'שם עמוד שגוי: {index} בטבלה {table}',
+    'Wrong params for chunk size: {size} or callback method is callable.' => 'Wrong params for chunk size: {size} or callback method is callable.',
 );

framework/messages/it/core.php

@@ -186,4 +186,5 @@
 	'You cannot delete the last remaining record in table {table}!' => 'Non è possibile eliminare l\'ultimo record rimasto nella tabella {table}!',
 	'Warnings' => 'Avvertenze',
 	'Wrong column name: {index} in table {table}' => 'Colonna sbagliato nome: {index} nella tabella {table}',
+    'Wrong params for chunk size: {size} or callback method is callable.' => 'Wrong params for chunk size: {size} or callback method is callable.',
 );

framework/messages/nl/core.php

@@ -181,9 +181,10 @@
 	'Unable to find the model class "{model}".' => 'Kan het model de klas "{model}".',
 	'Unknown' => 'Onbekend',
 	'Unknown operator "{operator}".' => 'Onbekende operator "{operator}".',
-	'Uploaded {file} is not a valid image! Please check carefully the file type.' => 'Ge�ploade file <strong>{file}</strong> is geen geldige afbeelding! Gelieve zorgvuldig te controleren het bestandstype.',
+	'Uploaded {file} is not a valid image! Please check carefully the file type.' => 'Geploade file <strong>{file}</strong> is geen geldige afbeelding! Gelieve zorgvuldig te controleren het bestandstype.',
 	'version' => 'versie',
 	'You cannot delete the last remaining record in table {table}!' => 'U kunt de laatst overgebleven record niet verwijderen in tabel {table}!',
 	'Warnings' => 'Waarschuwingen',
 	'Wrong column name: {index} in table {table}' => 'naam verkeerd column: {index} in tabel {table}',
+    'Wrong params for chunk size: {size} or callback method is callable.' => 'Wrong params for chunk size: {size} or callback method is callable.',
 );