Skip to content

Commit 0f59af4

Browse files
committed
enable & fix some warnings
1 parent 615d537 commit 0f59af4

File tree

5 files changed

+14
-1
lines changed

5 files changed

+14
-1
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ target_include_directories(flutterpi_module PUBLIC
168168
)
169169

170170
target_compile_options(flutterpi_module PUBLIC
171-
$<$<CONFIG:Debug>:-O0 -Wall -Wextra -Wno-sign-compare -Werror -ggdb -U_FORTIFY_SOURCE -DDEBUG>
171+
$<$<CONFIG:Debug>:-O0 -Wall -Wextra -Wno-sign-compare -Wswitch-enum -Wformat -Wdouble-promotion -Werror -ggdb -U_FORTIFY_SOURCE -DDEBUG>
172172
$<$<CONFIG:RelWithDebInfo>:-O3 -Wall -Wextra -Wno-sign-compare -ggdb -DNDEBUG>
173173
$<$<CONFIG:Release>:-O3 -Wall -Wextra -Wno-sign-compare -DNDEBUG>
174174
)

src/plugins/audioplayers/player.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,9 @@ struct audio_player *audio_player_new(char *player_id, char *channel) {
183183

184184
gboolean audio_player_on_bus_message(GstBus *bus, GstMessage *message, struct audio_player *data) {
185185
(void) bus;
186+
187+
PRAGMA_DIAGNOSTIC_PUSH
188+
PRAGMA_DIAGNOSTIC_IGNORED("-Wswitch-enum")
186189
switch (GST_MESSAGE_TYPE(message)) {
187190
case GST_MESSAGE_ERROR: {
188191
GError *err;
@@ -214,6 +217,7 @@ gboolean audio_player_on_bus_message(GstBus *bus, GstMessage *message, struct au
214217
// https://gstreamer.freedesktop.org/documentation/gstreamer/gstmessage.html?gi-language=c#enumerations
215218
break;
216219
}
220+
PRAGMA_DIAGNOSTIC_POP
217221

218222
// Continue watching for messages
219223
return TRUE;

src/plugins/gstreamer_video_player/frame.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -697,6 +697,8 @@ get_plane_infos(GstBuffer *buffer, const GstVideoInfo *info, struct gbm_device *
697697
}
698698

699699
static uint32_t drm_format_from_gst_info(const GstVideoInfo *info) {
700+
PRAGMA_DIAGNOSTIC_PUSH
701+
PRAGMA_DIAGNOSTIC_IGNORED("-Wswitch-enum")
700702
switch (GST_VIDEO_INFO_FORMAT(info)) {
701703
case GST_VIDEO_FORMAT_YUY2: return DRM_FORMAT_YUYV;
702704
case GST_VIDEO_FORMAT_YVYU: return DRM_FORMAT_YVYU;
@@ -730,6 +732,7 @@ static uint32_t drm_format_from_gst_info(const GstVideoInfo *info) {
730732
case GST_VIDEO_FORMAT_xBGR: return DRM_FORMAT_RGBX8888;
731733
default: return DRM_FORMAT_INVALID;
732734
}
735+
PRAGMA_DIAGNOSTIC_POP
733736
}
734737

735738
ATTR_CONST GstVideoFormat gst_video_format_from_drm_format(uint32_t drm_format) {

src/plugins/gstreamer_video_player/player.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -472,6 +472,9 @@ static void on_bus_message(struct gstplayer *player, GstMessage *msg) {
472472
gchar *debug_info;
473473

474474
DEBUG_TRACE_BEGIN(player, "on_bus_message");
475+
476+
PRAGMA_DIAGNOSTIC_PUSH
477+
PRAGMA_DIAGNOSTIC_IGNORED("-Wswitch-enum")
475478
switch (GST_MESSAGE_TYPE(msg)) {
476479
case GST_MESSAGE_ERROR:
477480
gst_message_parse_error(msg, &error, &debug_info);
@@ -604,6 +607,8 @@ static void on_bus_message(struct gstplayer *player, GstMessage *msg) {
604607

605608
default: LOG_DEBUG("gstreamer message: %s, src: %s\n", GST_MESSAGE_TYPE_NAME(msg), GST_MESSAGE_SRC_NAME(msg)); break;
606609
}
610+
PRAGMA_DIAGNOSTIC_POP
611+
607612
DEBUG_TRACE_END(player, "on_bus_message");
608613
return;
609614
}

src/vulkan.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ static inline const char *vk_strerror(VkResult result) {
8181
#if VK_HEADER_VERSION >= 213
8282
case VK_ERROR_COMPRESSION_EXHAUSTED_EXT: return "VK_ERROR_COMPRESSION_EXHAUSTED_EXT";
8383
#endif
84+
case VK_RESULT_MAX_ENUM:
8485
default: return "<unknown result code>";
8586
}
8687
}

0 commit comments

Comments
 (0)