Fix linter problems

Author: Mattia Bertorello

arduino-core/src/cc/arduino/utils/network/FileDownloaderCache.java

@@ -117,13 +117,13 @@ public class FileDownloaderCache {
     }
   }
 
-  static Optional<FileCached> getFileCached(final URL remoteURL)
+  public static Optional<FileCached> getFileCached(final URL remoteURL)
     throws URISyntaxException, NoSuchMethodException, ScriptException,
     IOException {
     return getFileCached(remoteURL, true);
   }
 
-  static Optional<FileCached> getFileCached(final URL remoteURL, boolean enableCache)
+  public static Optional<FileCached> getFileCached(final URL remoteURL, boolean enableCache)
     throws URISyntaxException, NoSuchMethodException, ScriptException,
     IOException {
     // Return always and empty file if the cache is not enable
@@ -305,15 +305,15 @@ public boolean exists() {
     }
 
     @JsonIgnore
-    Optional<File> getFileFromCache() {
+    public Optional<File> getFileFromCache() {
       if (md5Check()) {
         return Optional.of(Paths.get(localPath).toFile());
       }
       return Optional.empty();
 
     }
 
-    synchronized void updateCacheFile(File fileToCache) throws Exception {
+    public synchronized void updateCacheFile(File fileToCache) throws Exception {
       Path cacheFilePath = Paths.get(localPath);
 
       // If the cache directory does not exist create it
@@ -343,7 +343,7 @@ synchronized void updateCacheFile(File fileToCache) throws Exception {
 
     }
 
-    synchronized void invalidateCache() throws IOException {
+    public synchronized void invalidateCache() throws IOException {
       cachedFiles.remove(remoteURL);
       Files.deleteIfExists(Paths.get(localPath));
     }
@@ -356,7 +356,7 @@ private String calculateMD5() throws IOException, NoSuchAlgorithmException {
     }
 
     @JsonIgnore
-    boolean md5Check() {
+    public boolean md5Check() {
       try {
         return !Objects.isNull(getMD5()) && Objects.equals(calculateMD5(), getMD5());
       } catch (Exception e) {
@@ -366,7 +366,7 @@ boolean md5Check() {
     }
 
     @JsonIgnore
-    LocalDateTime getExpiresTime() {
+    public LocalDateTime getExpiresTime() {
       final int maxAge;
       if (cacheControl != null) {
         maxAge = cacheControl.getMaxAge();

arduino-core/src/processing/app/Platform.java

@@ -257,11 +257,9 @@ public synchronized Map<String, Object> resolveDeviceByVendorIdProductId(String
   }
 
   public static class BoardCloudAPIid {
-    public BoardCloudAPIid() {
-    }
 
-    private String name;
     private String fqbn;
+    private String name;
     private String architecture;
     private String id;