Merge remote-tracking branch 'sandeep/usb-send-timeout-take-2' into HEAD

Author: cmaglie

cores/arduino/USB/CDC.cpp

@@ -205,28 +205,14 @@ void Serial_::flush(void)
 
 size_t Serial_::write(const uint8_t *buffer, size_t size)
 {
-	/* only try to send bytes if the high-level CDC connection itself
-	 is open (not just the pipe) - the OS should set lineState when the port
-	 is opened and clear lineState when the port is closed.
-	 bytes sent before the user opens the connection or after
-	 the connection is closed are lost - just like with a UART. */
-
-	// TODO - ZE - check behavior on different OSes and test what happens if an
-	// open connection isn't broken cleanly (cable is yanked out, host dies
-	// or locks up, or host virtual serial port hangs)
-	if (_usbLineInfo.lineState > 0)  // Problem with Windows(R)
-	{
-		uint32_t r = usb.send(CDC_ENDPOINT_IN, buffer, size);
+	uint32_t r = usb.send(CDC_ENDPOINT_IN, buffer, size);
 
-		if (r > 0) {
-			return r;
-		} else {
-			setWriteError();
-			return 0;
-		}
+	if (r > 0) {
+		return r;
+	} else {
+		setWriteError();
+		return 0;
 	}
-	setWriteError();
-	return 0;
 }
 
 size_t Serial_::write(uint8_t c) {

cores/arduino/USB/USBCore.cpp

@@ -598,6 +598,19 @@ uint8_t USBDeviceClass::armRecv(uint32_t ep)
 	return usbd.epBank0ByteCount(ep);
 }
 
+// Timeout for sends
+#define TX_TIMEOUT_MS 70
+
+static char LastTransmitTimedOut[7] = {
+	0,
+	0,
+	0,
+	0,
+	0,
+	0,
+	0
+};
+
 // Blocking Send of data to an endpoint
 uint32_t USBDeviceClass::send(uint32_t ep, const void *data, uint32_t len)
 {
@@ -619,6 +632,29 @@ uint32_t USBDeviceClass::send(uint32_t ep, const void *data, uint32_t len)
 	// Flash area
 	while (len != 0)
 	{
+		if (usbd.epBank1IsReady(ep)) {
+			// previous transfer is still not complete
+
+			// convert the timeout from microseconds to a number of times through
+			// the wait loop; it takes (roughly) 23 clock cycles per iteration.
+			uint32_t timeout = microsecondsToClockCycles(TX_TIMEOUT_MS * 1000) / 23;
+
+			// Wait for (previous) transfer to complete
+			// inspired by Paul Stoffregen's work on Teensy
+			while (!usbd.epBank1IsTransferComplete(ep)) {
+				if (LastTransmitTimedOut[ep] || timeout-- == 0) {
+					LastTransmitTimedOut[ep] = 1;
+
+					// set byte count to zero, so that ZLP is sent
+					// instead of stale data
+					usbd.epBank1SetByteCount(ep, 0);
+					return -1;
+				}
+			}
+		}
+
+		LastTransmitTimedOut[ep] = 0;
+
 		if (len >= EPX_SIZE) {
 			length = EPX_SIZE - 1;
 		} else {
@@ -637,10 +673,6 @@ uint32_t USBDeviceClass::send(uint32_t ep, const void *data, uint32_t len)
 		// RAM buffer is full, we can send data (IN)
 		usbd.epBank1SetReady(ep);
 
-		// Wait for transfer to complete
-		while (!usbd.epBank1IsTransferComplete(ep)) {
-			;  // need fire exit.
-		}
 		written += length;
 		len -= length;
 		data = (char *)data + length;